Bug 198983 - [WASM-References] Rename anyfunc to funcref
Summary: [WASM-References] Rename anyfunc to funcref
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Justin Michaud
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-18 16:43 PDT by Justin Michaud
Modified: 2019-06-19 08:37 PDT (History)
9 users (show)

See Also:


Attachments
Patch (133.77 KB, patch)
2019-06-18 18:39 PDT, Justin Michaud
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews211 for win-future (13.81 MB, application/zip)
2019-06-18 22:26 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Michaud 2019-06-18 16:43:57 PDT
Anyfunc should become funcref since it was renamed in the spec. We should also support the string 'anyfunc' in the table constructor since this is the only non-binary-format place where it is exposed to users.
Comment 1 Justin Michaud 2019-06-18 18:39:17 PDT
Created attachment 372416 [details]
Patch
Comment 2 Build Bot 2019-06-18 18:41:36 PDT
This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at "Source/JavaScriptCore/wasm/wasm.json" and "JSTests/wasm/wasm.json".
Comment 3 Yusuke Suzuki 2019-06-18 18:43:15 PDT
Comment on attachment 372416 [details]
Patch

r=me
Comment 4 Build Bot 2019-06-18 22:26:30 PDT
Comment on attachment 372416 [details]
Patch

Attachment 372416 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12516291

New failing tests:
svg/text/textpath-reference-update.html
Comment 5 Build Bot 2019-06-18 22:26:33 PDT
Created attachment 372434 [details]
Archive of layout-test-results from ews211 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 6 Justin Michaud 2019-06-19 08:05:01 PDT
Comment on attachment 372416 [details]
Patch

Test failures seem unrelated.
Comment 7 WebKit Commit Bot 2019-06-19 08:36:53 PDT
Comment on attachment 372416 [details]
Patch

Clearing flags on attachment: 372416

Committed r246589: <https://trac.webkit.org/changeset/246589>
Comment 8 WebKit Commit Bot 2019-06-19 08:36:55 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-06-19 08:37:21 PDT
<rdar://problem/51896943>