Bug 198981 - DownloadMonitor::measuredThroughputRate should approach zero with no throughput
Summary: DownloadMonitor::measuredThroughputRate should approach zero with no throughput
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-18 16:29 PDT by Alex Christensen
Modified: 2019-06-19 16:36 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.37 KB, patch)
2019-06-18 16:42 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-06-18 16:29:07 PDT 
DownloadMonitor::measuredThroughputRate should approach zero with no throughput
Comment 1 Alex Christensen 2019-06-18 16:42:01 PDT 
Created attachment 372405 [details]
Patch
Comment 2 Alex Christensen 2019-06-18 16:42:04 PDT 
<rdar://problem/51456914>
Comment 3 Geoffrey Garen 2019-06-19 10:31:23 PDT 
Comment on attachment 372405 [details]
Patch

r=me

I wonder if our API test can cover this. You'd need to add a way to explicitly set the timer duration for testing, so the test didn't take five minutes. A little gross, but seems doable.
Comment 4 Alex Christensen 2019-06-19 16:06:44 PDT 
Comment on attachment 372405 [details]
Patch

We don't have a good way to simulate packet loss.
Comment 5 WebKit Commit Bot 2019-06-19 16:36:41 PDT 
Comment on attachment 372405 [details]
Patch

Clearing flags on attachment: 372405

Committed r246615: <https://trac.webkit.org/changeset/246615>
Comment 6 WebKit Commit Bot 2019-06-19 16:36:43 PDT 
All reviewed patches have been landed.  Closing bug.