Bug 198974 - Update WebKit API to separately retrieve actions and use context menus
Summary: Update WebKit API to separately retrieve actions and use context menus
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-18 13:22 PDT by Alex Christensen
Modified: 2019-06-19 11:02 PDT (History)
8 users (show)

See Also:


Attachments
Patch (15.94 KB, patch)
2019-06-18 13:25 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (8.23 KB, patch)
2019-06-18 15:27 PDT, Alex Christensen
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-06-18 13:22:26 PDT
Update WebKit API to separately retrieve actions and use context menus
Comment 1 Alex Christensen 2019-06-18 13:25:00 PDT
Created attachment 372371 [details]
Patch
Comment 2 Alex Christensen 2019-06-18 13:25:02 PDT
<rdar://problem/50735687>
Comment 3 Tim Horton 2019-06-18 15:09:58 PDT
Comment on attachment 372371 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372371&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKUIDelegate.h:170
> +- (void)webView:(WKWebView *)webView contextMenuConfigurationForElement:(WKContextMenuElementInfo *)elementInfo completionHandler:(void (^)(UIContextMenuConfiguration * _Nullable))completionHandler WK_API_AVAILABLE(ios(WK_IOS_TBA));

I think you want to name the block parameters so that Xcode pops a name in for you? We do in other places.

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:489
> +- (void)ensurePositionInformationIsUpToDate:(const WebKit::InteractionInformationRequest&)request completionHandler:(CompletionHandler<void(BOOL)>&&)completionHandler;

I don't think we need an additional way to get async position information updates; see above.
Comment 4 Alex Christensen 2019-06-18 15:27:06 PDT
Created attachment 372391 [details]
Patch
Comment 5 WebKit Commit Bot 2019-06-18 16:09:42 PDT
Comment on attachment 372391 [details]
Patch

Rejecting attachment 372391 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 372391, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=372391&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=198974&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 372391 from bug 198974.
Fetching: https://bugs.webkit.org/attachment.cgi?id=372391
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 3 diffs from patch file(s).
patching file Source/WebKit/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit/UIProcess/API/Cocoa/WKUIDelegate.h
Hunk #1 succeeded at 45 with fuzz 2 (offset 6 lines).
Hunk #2 FAILED at 141.
Hunk #3 FAILED at 156.
2 out of 3 hunks FAILED -- saving rejects to file Source/WebKit/UIProcess/API/Cocoa/WKUIDelegate.h.rej
patching file Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h
Hunk #1 FAILED at 147.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 3 diffs from patch file(s).
patching file Source/WebKit/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit/UIProcess/API/Cocoa/WKUIDelegate.h
Hunk #1 succeeded at 45 with fuzz 2 (offset 6 lines).
Hunk #2 FAILED at 141.
Hunk #3 FAILED at 156.
2 out of 3 hunks FAILED -- saving rejects to file Source/WebKit/UIProcess/API/Cocoa/WKUIDelegate.h.rej
patching file Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h
Hunk #1 FAILED at 147.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
From https://git.webkit.org/git/WebKit
   4a8cbd8f81f..50e451c1e4c  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 246572 = 4a8cbd8f81fbb759640f01fd804aa90361784fc6
r246573 = a49db596d6b7c9466c743d99f3879840310f23f4
r246574 = 4a74c0a384396b431f750f144c52f50ae70d3656
r246575 = 4b20a15db3add74bf10b1bd28986f3ce0afbcff2
r246576 = 50e451c1e4c55505257a6ac5faa3a629e99b8f89
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: https://webkit-queues.webkit.org/results/12513573
Comment 6 Alex Christensen 2019-06-18 21:31:52 PDT
https://trac.webkit.org/changeset/246575/webkit
Comment 7 Ryan Haddad 2019-06-18 21:44:17 PDT
Reverted r246575 for reason:

Breaks internal builds.

Committed r246580: <https://trac.webkit.org/changeset/246580>
Comment 8 Alex Christensen 2019-06-19 11:02:11 PDT
This was relanded in these two patches:

https://trac.webkit.org/changeset/246583/webkit
http://trac.webkit.org/r246598