Bug 198972 - webkit-patch should allow for a bugzilla url not just bugzilla id
Summary: webkit-patch should allow for a bugzilla url not just bugzilla id
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-18 12:05 PDT by Keith Miller
Modified: 2019-06-18 14:12 PDT (History)
7 users (show)

See Also:


Attachments
Patch (2.80 KB, patch)
2019-06-18 12:06 PDT, Keith Miller
no flags Details | Formatted Diff | Diff
Patch for landing (2.76 KB, patch)
2019-06-18 13:29 PDT, Keith Miller
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2019-06-18 12:05:07 PDT
webkit-patch should allow for a bugzilla url not just bugzilla id
Comment 1 Keith Miller 2019-06-18 12:06:43 PDT
Created attachment 372359 [details]
Patch
Comment 2 dewei_zhu 2019-06-18 13:24:23 PDT
Comment on attachment 372359 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372359&action=review

> Tools/Scripts/webkitpy/tool/steps/promptforbugortitle.py:61
> +                1

use 'pass'
Comment 3 dewei_zhu 2019-06-18 13:25:36 PDT
Comment on attachment 372359 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372359&action=review

> Tools/Scripts/webkitpy/tool/steps/promptforbugortitle.py:51
> +            parsed_url = None

You doin't need to initialize a parsed_url here.
Comment 4 Keith Miller 2019-06-18 13:29:05 PDT
Created attachment 372373 [details]
Patch for landing
Comment 5 Keith Miller 2019-06-18 13:30:05 PDT
(In reply to dewei_zhu from comment #3)
> Comment on attachment 372359 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=372359&action=review
> 
> > Tools/Scripts/webkitpy/tool/steps/promptforbugortitle.py:51
> > +            parsed_url = None
> 
> You doin't need to initialize a parsed_url here.

As discussed offline. I meant to move the code out of the try catch block, which I have done for the final patch.
Comment 6 WebKit Commit Bot 2019-06-18 14:11:37 PDT
Comment on attachment 372373 [details]
Patch for landing

Clearing flags on attachment: 372373

Committed r246566: <https://trac.webkit.org/changeset/246566>
Comment 7 WebKit Commit Bot 2019-06-18 14:11:38 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-06-18 14:12:28 PDT
<rdar://problem/51865072>