Bug 198970 – Change log channel name from ResourceLoadStatisticsDebug to ITPDebug and remove unnecessary #if !RELEASE_LOG_DISABLED

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[John Wilander]

We should change the log channel name for ITP from ResourceLoadStatisticsDebug to ITPDebug and remove unnecessary #if !RELEASE_LOG_DISABLED while we're at it.

[Radar WebKit Bug Importer]

<rdar://problem/51855836>

[John Wilander]

Created attachment 372351 [details]
Patch

[Brent Fulgham]

Comment on attachment 372351 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372351&action=review

Looks good, aside from the unused function. r=me if you fix that.

> Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp:-89
> -#endif

I think the build will fail (due to unused function warnings) if you remove these #if/defs.

[John Wilander]

(In reply to Brent Fulgham from comment #3)
> Comment on attachment 372351 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=372351&action=review
> 
> Looks good, aside from the unused function. r=me if you fix that.
> 
> > Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp:-89
> > -#endif
> 
> I think the build will fail (due to unused function warnings) if you remove
> these #if/defs.

Oh, you're saying the RELEASE_LOG_INFO macros will compile out the calls to domainsToString() if release log is disabled and thus cause an unused function build warning/failure?

[John Wilander]

Created attachment 372357 [details]
Patch

[John Wilander]

Made the change you asked for and now just making sure EWS is happy since it's a compile-time change.

[Brent Fulgham]

(In reply to John Wilander from comment #4)
> (In reply to Brent Fulgham from comment #3)
> > Comment on attachment 372351 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=372351&action=review
> > 
> > Looks good, aside from the unused function. r=me if you fix that.
> > 
> > > Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp:-89
> > > -#endif
> > 
> > I think the build will fail (due to unused function warnings) if you remove
> > these #if/defs.
> 
> Oh, you're saying the RELEASE_LOG_INFO macros will compile out the calls to
> domainsToString() if release log is disabled and thus cause an unused
> function build warning/failure?

Precisely! It's because we build with warnings-as-errors.

[John Wilander]

Comment on attachment 372357 [details]
Patch

Seems fine. Thanks, Brent!

[WebKit Commit Bot]

Comment on attachment 372357 [details]
Patch

Clearing flags on attachment: 372357

Committed r246561: <https://trac.webkit.org/changeset/246561>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.