Bug 198954 - REGRESSION: _WKDownload.OriginatingWebView and _WKDownload.CrashAfterDownloadDidFinishWhenDownloadProxyHoldsTheLastRefOnWebProcessPool failing
Summary: REGRESSION: _WKDownload.OriginatingWebView and _WKDownload.CrashAfterDownload...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-17 22:20 PDT by David Quesada
Modified: 2019-06-18 10:20 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.64 KB, patch)
2019-06-17 22:35 PDT, David Quesada 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Quesada 2019-06-17 22:20:32 PDT 
rdar://problem/51711556
Comment 1 David Quesada 2019-06-17 22:35:20 PDT 
Created attachment 372328 [details]
Patch
Comment 2 David Quesada 2019-06-17 22:39:27 PDT 
Before this patch, I ran 30 iterations of these tests locally and saw success rates of 21/30 and 25/30. With this patch, I've run 200 iterations (so far) and haven't seen any failures of either.
Comment 3 WebKit Commit Bot 2019-06-18 10:20:20 PDT 
Comment on attachment 372328 [details]
Patch

Clearing flags on attachment: 372328

Committed r246548: <https://trac.webkit.org/changeset/246548>
Comment 4 WebKit Commit Bot 2019-06-18 10:20:22 PDT 
All reviewed patches have been landed.  Closing bug.