Bug 198951 – Web Inspector: Network: detail view shouldn't stay open when the related entry is removed

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

# STEPS TO REPRODUCE:
1. inspect any page
2. go to the Network tab
3. reload the inspected page
4. select any entry in the Network tab
5. reload the inspected page
 => the detail view stays open

[Devin Rousso]

Created attachment 372320 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 372320 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372320&action=review

Good catch! r-me

> Source/WebInspectorUI/UserInterface/Views/Table.js:285
> -        for (let rowIndex = this._visibleRowIndexStart; rowIndex < this._visibleRowIndexEnd; ++rowIndex) {
> +        let numberOfRows = this.numberOfRows;
> +        for (let rowIndex = this._visibleRowIndexStart; rowIndex < Math.min(this._visibleRowIndexEnd, numberOfRows); ++rowIndex) {

You should be able to move the `Math.min` calculation out of the loop so it is only performed once:

    let endIndex = Math.min(this._visibleRowIndexEnd, this.numberOfRows);

[Devin Rousso]

Created attachment 372358 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 372358 [details]
Patch

Clearing flags on attachment: 372358

Committed r246560: <https://trac.webkit.org/changeset/246560>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/51861653>