Bug 198947 - NetworkSession::networkStorageSession can return null
Summary: NetworkSession::networkStorageSession can return null
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-17 17:55 PDT by Alex Christensen
Modified: 2019-06-18 14:40 PDT (History)
3 users (show)

See Also:

Attachments
Patch (16.91 KB, patch)
2019-06-17 17:57 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (30.93 KB, patch)
2019-06-17 18:01 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-06-17 17:55:43 PDT 
NetworkSession::networkStorageSession can return null
Comment 1 Alex Christensen 2019-06-17 17:57:44 PDT 
Created attachment 372304 [details]
Patch
Comment 2 Alex Christensen 2019-06-17 17:57:46 PDT 
<rdar://problem/51394449>
Comment 3 Alex Christensen 2019-06-17 18:01:59 PDT 
Created attachment 372307 [details]
Patch
Comment 4 youenn fablet 2019-06-18 10:28:05 PDT 
Comment on attachment 372307 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372307&action=review

> Source/WebKit/ChangeLog:22
> +        (WebKit::WebResourceLoadStatisticsStore::removePrevalentDomains):

ResourceLoadStatisticsStore.cpp/WebResourceLoadStatisticsStore changes should probably not be needed after changes landed in https://bugs.webkit.org/show_bug.cgi?id=198814.
Comment 5 Alex Christensen 2019-06-18 14:20:13 PDT 
Comment on attachment 372307 [details]
Patch

They're just null checks, and a syntax change is needed no matter what, so I'll just land this.  When we fix bug 194926 we'll be back to having references.
Comment 6 WebKit Commit Bot 2019-06-18 14:40:33 PDT 
Comment on attachment 372307 [details]
Patch

Clearing flags on attachment: 372307

Committed r246569: <https://trac.webkit.org/changeset/246569>
Comment 7 WebKit Commit Bot 2019-06-18 14:40:35 PDT 
All reviewed patches have been landed.  Closing bug.