Bug 198941 - Web Inspector: REGRESSION: Heap: subsequent snapshots taken manually don't appear in the list
Summary: Web Inspector: REGRESSION: Heap: subsequent snapshots taken manually don't ap...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-17 16:51 PDT by Devin Rousso
Modified: 2019-06-18 12:34 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.62 KB, patch)
2019-06-17 21:47 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (2.71 KB, patch)
2019-06-17 21:49 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-06-17 16:51:23 PDT
# STEPS TO REPRODUCE:
1. inspect any page
2. go to the Timelines tab
3. enable "JavaScript Allocations"
4. take a heap snapshot
 => the [S] appears in the graph area and in the "Snapshot List" area
5. take another heap snapshot
 => the [S] appears in the graph area, but _not_ in the "Snapshot List" area
Comment 1 Devin Rousso 2019-06-17 21:26:45 PDT
Interestingly, it looks like it's only an issue when the entire recording is selected (e.g. double clicking the overview graph area).
Comment 2 Devin Rousso 2019-06-17 21:47:54 PDT
Created attachment 372323 [details]
Patch
Comment 3 Devin Rousso 2019-06-17 21:49:03 PDT
Created attachment 372324 [details]
Patch

webkit-patch didn't catch my last changes :(
Comment 4 Joseph Pecoraro 2019-06-18 11:44:00 PDT
Comment on attachment 372324 [details]
Patch

Nice, r=me
Comment 5 WebKit Commit Bot 2019-06-18 12:33:48 PDT
Comment on attachment 372324 [details]
Patch

Clearing flags on attachment: 372324

Committed r246558: <https://trac.webkit.org/changeset/246558>
Comment 6 WebKit Commit Bot 2019-06-18 12:33:49 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-06-18 12:34:28 PDT
<rdar://problem/51860940>