Convert macOS to scroll by changing layer boundsOrigin
Created attachment 372246 [details] Patch
Just needs a bit more cleanup before reviewing (if tests pass).
Comment on attachment 372246 [details] Patch Attachment 372246 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12497805 New failing tests: compositing/repaint/iframes/compositing-iframe-scroll-repaint.html compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint.html
Created attachment 372251 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 372246 [details] Patch Attachment 372246 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12497848 New failing tests: tiled-drawing/scrolling/overflow/overflow-scrolled-down-tile-coverage.html tiled-drawing/scrolling/overflow/overflow-scrolled-up-tile-coverage.html
Created attachment 372252 [details] Archive of layout-test-results from ews107 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 372246 [details] Patch Attachment 372246 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12497902 New failing tests: compositing/repaint/iframes/compositing-iframe-scroll-repaint.html compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint.html
Created attachment 372254 [details] Archive of layout-test-results from ews117 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 372246 [details] Patch Attachment 372246 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12498052 New failing tests: compositing/iframes/scrolling-iframe.html scrollingcoordinator/scrolling-tree/fixed-inside-frame.html
Created attachment 372255 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5
Created attachment 372276 [details] Patch
Comment on attachment 372276 [details] Patch Attachment 372276 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12501357 New failing tests: compositing/repaint/iframes/compositing-iframe-scroll-repaint.html compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint.html
Created attachment 372284 [details] Archive of layout-test-results from ews103 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 372276 [details] Patch Attachment 372276 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12500962 New failing tests: compositing/repaint/iframes/compositing-iframe-scroll-repaint.html compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint.html
Created attachment 372285 [details] Archive of layout-test-results from ews115 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 372302 [details] Patch
Comment on attachment 372302 [details] Patch Attachment 372302 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12503139 New failing tests: compositing/repaint/iframes/compositing-iframe-scroll-repaint.html
Created attachment 372311 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 372302 [details] Patch Attachment 372302 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12503519 New failing tests: compositing/repaint/iframes/compositing-iframe-scroll-repaint.html
Created attachment 372317 [details] Archive of layout-test-results from ews114 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 372322 [details] Patch
Comment on attachment 372322 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372322&action=review > Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp:-450 > - // Doing all scrolling like this (UIScrollView style) would simplify code. Nice
Comment on attachment 372322 [details] Patch Clearing flags on attachment: 372322 Committed r246538: <https://trac.webkit.org/changeset/246538>
All reviewed patches have been landed. Closing bug.
<rdar://problem/51849792>
The changes in https://trac.webkit.org/changeset/246538/webkit has broken compositing/repaint/iframes/compositing-iframe-scroll-repaint.html on Mojave WK1. I was able to reproduce this locally. History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=compositing%2Frepaint%2Fiframes%2Fcompositing-iframe-scroll-repaint.html Diff: --- /Volumes/Data/slave/mojave-release-tests-wk1/build/layout-test-results/compositing/repaint/iframes/compositing-iframe-scroll-repaint-expected.txt +++ /Volumes/Data/slave/mojave-release-tests-wk1/build/layout-test-results/compositing/repaint/iframes/compositing-iframe-scroll-repaint-actual.txt @@ -34,12 +34,6 @@ (GraphicsLayer (bounds 400.00 1016.00) (drawsContent 1) - (repaint rects - (rect 0.00 0.00 400.00 1016.00) - (rect 0.00 0.00 400.00 1016.00) - (rect 8.00 8.00 384.00 1000.00) - (rect 0.00 0.00 400.00 1016.00) - ) (children 1 (GraphicsLayer (position 8.00 8.00)
Partially reverted in https://trac.webkit.org/r246612