198917 – Convert macOS to scroll by changing layer boundsOrigin

RESOLVED FIXED 198917

Convert macOS to scroll by changing layer boundsOrigin

https://bugs.webkit.org/show_bug.cgi?id=198917

Summary Convert macOS to scroll by changing layer boundsOrigin

Simon Fraser (smfr)

Reported 2019-06-17 08:36:10 PDT

Convert macOS to scroll by changing layer boundsOrigin

Attachments
Patch (30.51 KB, patch) 2019-06-17 08:38 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-highsierra (3.21 MB, application/zip) 2019-06-17 09:47 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-highsierra-wk2 (2.74 MB, application/zip) 2019-06-17 09:55 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews117 for mac-highsierra (3.02 MB, application/zip) 2019-06-17 10:28 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.59 MB, application/zip) 2019-06-17 10:36 PDT, EWS Watchlist	no flags	Details
Patch (37.65 KB, patch) 2019-06-17 14:34 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-highsierra (3.19 MB, application/zip) 2019-06-17 16:25 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews115 for mac-highsierra (3.03 MB, application/zip) 2019-06-17 16:28 PDT, EWS Watchlist	no flags	Details
Patch (40.81 KB, patch) 2019-06-17 17:46 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-highsierra (3.34 MB, application/zip) 2019-06-17 18:31 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews114 for mac-highsierra (2.97 MB, application/zip) 2019-06-17 19:34 PDT, EWS Watchlist	no flags	Details
Patch (40.81 KB, patch) 2019-06-17 21:44 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Show Obsolete (11) View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2019-06-17 08:38:50 PDT

Created attachment 372246 [details] Patch

Simon Fraser (smfr)

Comment 2 2019-06-17 08:39:23 PDT

Just needs a bit more cleanup before reviewing (if tests pass).

EWS Watchlist

Comment 3 2019-06-17 09:47:56 PDT Comment hidden (obsolete)

Comment on attachment 372246 [details] Patch Attachment 372246 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12497805 New failing tests: compositing/repaint/iframes/compositing-iframe-scroll-repaint.html compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint.html

EWS Watchlist

Comment 4 2019-06-17 09:47:58 PDT Comment hidden (obsolete)

Created attachment 372251 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 5 2019-06-17 09:55:04 PDT Comment hidden (obsolete)

Comment on attachment 372246 [details] Patch Attachment 372246 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12497848 New failing tests: tiled-drawing/scrolling/overflow/overflow-scrolled-down-tile-coverage.html tiled-drawing/scrolling/overflow/overflow-scrolled-up-tile-coverage.html

EWS Watchlist

Comment 6 2019-06-17 09:55:06 PDT Comment hidden (obsolete)

Created attachment 372252 [details] Archive of layout-test-results from ews107 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 7 2019-06-17 10:28:16 PDT Comment hidden (obsolete)

Comment on attachment 372246 [details] Patch Attachment 372246 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12497902 New failing tests: compositing/repaint/iframes/compositing-iframe-scroll-repaint.html compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint.html

EWS Watchlist

Comment 8 2019-06-17 10:28:18 PDT Comment hidden (obsolete)

Created attachment 372254 [details] Archive of layout-test-results from ews117 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 9 2019-06-17 10:36:11 PDT Comment hidden (obsolete)

Comment on attachment 372246 [details] Patch Attachment 372246 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12498052 New failing tests: compositing/iframes/scrolling-iframe.html scrollingcoordinator/scrolling-tree/fixed-inside-frame.html

EWS Watchlist

Comment 10 2019-06-17 10:36:12 PDT Comment hidden (obsolete)

Created attachment 372255 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5

Simon Fraser (smfr)

Comment 11 2019-06-17 14:34:38 PDT Comment hidden (obsolete)

Created attachment 372276 [details] Patch

EWS Watchlist

Comment 12 2019-06-17 16:25:42 PDT Comment hidden (obsolete)

Comment on attachment 372276 [details] Patch Attachment 372276 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12501357 New failing tests: compositing/repaint/iframes/compositing-iframe-scroll-repaint.html compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint.html

EWS Watchlist

Comment 13 2019-06-17 16:25:44 PDT Comment hidden (obsolete)

Created attachment 372284 [details] Archive of layout-test-results from ews103 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 14 2019-06-17 16:28:48 PDT Comment hidden (obsolete)

Comment on attachment 372276 [details] Patch Attachment 372276 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12500962 New failing tests: compositing/repaint/iframes/compositing-iframe-scroll-repaint.html compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint.html

EWS Watchlist

Comment 15 2019-06-17 16:28:50 PDT Comment hidden (obsolete)

Created attachment 372285 [details] Archive of layout-test-results from ews115 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-highsierra Platform: Mac OS X 10.13.6

Simon Fraser (smfr)

Comment 16 2019-06-17 17:46:58 PDT Comment hidden (obsolete)

Created attachment 372302 [details] Patch

EWS Watchlist

Comment 17 2019-06-17 18:31:48 PDT Comment hidden (obsolete)

Comment on attachment 372302 [details] Patch Attachment 372302 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12503139 New failing tests: compositing/repaint/iframes/compositing-iframe-scroll-repaint.html

EWS Watchlist

Comment 18 2019-06-17 18:31:49 PDT Comment hidden (obsolete)

Created attachment 372311 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 19 2019-06-17 19:34:20 PDT Comment hidden (obsolete)

Comment on attachment 372302 [details] Patch Attachment 372302 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12503519 New failing tests: compositing/repaint/iframes/compositing-iframe-scroll-repaint.html

EWS Watchlist

Comment 20 2019-06-17 19:34:22 PDT Comment hidden (obsolete)

Created attachment 372317 [details] Archive of layout-test-results from ews114 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-highsierra Platform: Mac OS X 10.13.6

Simon Fraser (smfr)

Comment 21 2019-06-17 21:44:10 PDT

Created attachment 372322 [details] Patch

Antti Koivisto

Comment 22 2019-06-18 00:45:00 PDT

Comment on attachment 372322 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372322&action=review > Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp:-450 > - // Doing all scrolling like this (UIScrollView style) would simplify code. Nice

WebKit Commit Bot

Comment 23 2019-06-18 08:16:39 PDT

Comment on attachment 372322 [details] Patch Clearing flags on attachment: 372322 Committed r246538: <https://trac.webkit.org/changeset/246538>

WebKit Commit Bot

Comment 24 2019-06-18 08:16:41 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 25 2019-06-18 08:17:19 PDT

<rdar://problem/51849792>

Truitt Savell

Comment 26 2019-06-19 13:29:06 PDT

The changes in https://trac.webkit.org/changeset/246538/webkit has broken compositing/repaint/iframes/compositing-iframe-scroll-repaint.html on Mojave WK1. I was able to reproduce this locally. History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=compositing%2Frepaint%2Fiframes%2Fcompositing-iframe-scroll-repaint.html Diff: --- /Volumes/Data/slave/mojave-release-tests-wk1/build/layout-test-results/compositing/repaint/iframes/compositing-iframe-scroll-repaint-expected.txt +++ /Volumes/Data/slave/mojave-release-tests-wk1/build/layout-test-results/compositing/repaint/iframes/compositing-iframe-scroll-repaint-actual.txt @@ -34,12 +34,6 @@ (GraphicsLayer (bounds 400.00 1016.00) (drawsContent 1) - (repaint rects - (rect 0.00 0.00 400.00 1016.00) - (rect 0.00 0.00 400.00 1016.00) - (rect 8.00 8.00 384.00 1000.00) - (rect 0.00 0.00 400.00 1016.00) - ) (children 1 (GraphicsLayer (position 8.00 8.00)

Simon Fraser (smfr)

Comment 27 2019-06-19 14:47:48 PDT

Partially reverted in https://trac.webkit.org/r246612

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component New Bugs

Assignee

Simon Fraser (smfr)

Reported

2019-06-17 08:36 PDT

Modified

2019-06-19 14:47 PDT History

CC List

8 users Show

URL

Keywords InRadar

Depends on

Blocks