Bug 198916 - [GStreamer] Identify elements with monotonically increasing counters
Summary: [GStreamer] Identify elements with monotonically increasing counters
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-17 07:53 PDT by Philippe Normand
Modified: 2019-06-18 07:49 PDT (History)
3 users (show)

See Also:


Attachments
Patch (4.92 KB, patch)
2019-06-17 07:59 PDT, Philippe Normand
calvaris: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2019-06-17 07:53:38 PDT
.
Comment 1 Philippe Normand 2019-06-17 07:59:24 PDT
Created attachment 372245 [details]
Patch
Comment 2 Xabier Rodríguez Calvar 2019-06-17 23:59:35 PDT
Comment on attachment 372245 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372245&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2389
> +    static Atomic<uint32_t> pipelineId = 0;

I guess you don't need to initialize this because it is the only place were you do it.
Comment 3 Philippe Normand 2019-06-18 07:48:08 PDT
Committed r246537: <https://trac.webkit.org/changeset/246537>
Comment 4 Radar WebKit Bug Importer 2019-06-18 07:49:30 PDT
<rdar://problem/51848852>