RESOLVED FIXED 198901
[LFC][IFC] Decouple baseline ascent/descent and baseline offset. 
https://bugs.webkit.org/show_bug.cgi?id=198901
Summary [LFC][IFC] Decouple baseline ascent/descent and baseline offset.
zalan
Reported 2019-06-15 20:54:00 PDT
baseline offset = baseline top + baseline ascent (baseline's distance from the top of the line -not always the same as baseline ascent)
Attachments
Patch (9.58 KB, patch)
2019-06-15 20:59 PDT, zalan 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-06-15 20:54:25 PDT
<rdar://problem/51782393>
zalan
Comment 2 2019-06-15 20:59:44 PDT
Created attachment 372215 [details] Patch
Antti Koivisto
Comment 3 2019-06-16 11:59:52 PDT
Comment on attachment 372215 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372215&action=review > Source/WebCore/layout/inlineformatting/InlineLineBox.h:54 > + // baseline offset from line logical top. Note that offset does not necessarily equal to ascent. Start with capital letter. This could use some ascii art!
zalan
Comment 4 2019-06-16 12:00:56 PDT
(In reply to Antti Koivisto from comment #3) > Comment on attachment 372215 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=372215&action=review > > > Source/WebCore/layout/inlineformatting/InlineLineBox.h:54 > > + // baseline offset from line logical top. Note that offset does not necessarily equal to ascent. > > Start with capital letter. > > This could use some ascii art! Indeed!
zalan
Comment 5 2019-06-16 13:42:04 PDT
Committed r246484: <https://trac.webkit.org/changeset/246484>
Note You need to log in before you can comment on or make changes to this bug.