Bug 198901 - [LFC][IFC] Decouple baseline ascent/descent and baseline offset.
Summary: [LFC][IFC] Decouple baseline ascent/descent and baseline offset.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-15 20:54 PDT by zalan
Modified: 2019-06-16 13:42 PDT (History)
5 users (show)

See Also:

Attachments
Patch (9.58 KB, patch)
2019-06-15 20:59 PDT, zalan 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-06-15 20:54:00 PDT 
baseline offset = baseline top + baseline ascent (baseline's distance from the top of the line -not always the same as baseline ascent)
Comment 1 Radar WebKit Bug Importer 2019-06-15 20:54:25 PDT 
<rdar://problem/51782393>
Comment 2 zalan 2019-06-15 20:59:44 PDT 
Created attachment 372215 [details]
Patch
Comment 3 Antti Koivisto 2019-06-16 11:59:52 PDT 
Comment on attachment 372215 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372215&action=review

> Source/WebCore/layout/inlineformatting/InlineLineBox.h:54
> +    // baseline offset from line logical top. Note that offset does not necessarily equal to ascent.

Start with capital letter.

This could use some ascii art!
Comment 4 zalan 2019-06-16 12:00:56 PDT 
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 372215 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=372215&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineLineBox.h:54
> > +    // baseline offset from line logical top. Note that offset does not necessarily equal to ascent.
> 
> Start with capital letter.
> 
> This could use some ascii art!
Indeed!
Comment 5 zalan 2019-06-16 13:42:04 PDT 
Committed r246484: <https://trac.webkit.org/changeset/246484>