Bug 198891 – [LFC][IFC] Intruding float may prevent adding any inline box

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

ssia

[Radar WebKit Bug Importer]

<rdar://problem/51779956>

[zalan]

Created attachment 372199 [details]
Patch

[Antti Koivisto]

Comment on attachment 372199 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372199&action=review

> Source/WebCore/layout/LayoutUnits.h:62
> +    static Point max() { return Point(LayoutUnit::max(), LayoutUnit::max()); }

return { .. } would work I suppose.

> Source/WebCore/layout/LayoutUnits.h:64
>      void moveBy(LayoutPoint);

Not from this patch but moving a Point by a Point is not good semantically. It would be if you had to explicitly turn Point to Size first. This is how IntPoint etc work.

[Antti Koivisto]

*would be better

[Antti Koivisto]

> > Source/WebCore/layout/LayoutUnits.h:64
> >      void moveBy(LayoutPoint);
> 
> Not from this patch but moving a Point by a Point is not good semantically.
> It would be if you had to explicitly turn Point to Size first. This is how
> IntPoint etc work.

Well, this is not really true. IntPoint makes difference between move and moveBy where later takes an offset point.

[zalan]

Committed r246483: <https://trac.webkit.org/changeset/246483>