ssia
<rdar://problem/51779956>
Created attachment 372199 [details] Patch
Comment on attachment 372199 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372199&action=review > Source/WebCore/layout/LayoutUnits.h:62 > + static Point max() { return Point(LayoutUnit::max(), LayoutUnit::max()); } return { .. } would work I suppose. > Source/WebCore/layout/LayoutUnits.h:64 > void moveBy(LayoutPoint); Not from this patch but moving a Point by a Point is not good semantically. It would be if you had to explicitly turn Point to Size first. This is how IntPoint etc work.
*would be better
> > Source/WebCore/layout/LayoutUnits.h:64 > > void moveBy(LayoutPoint); > > Not from this patch but moving a Point by a Point is not good semantically. > It would be if you had to explicitly turn Point to Size first. This is how > IntPoint etc work. Well, this is not really true. IntPoint makes difference between move and moveBy where later takes an offset point.
Committed r246483: <https://trac.webkit.org/changeset/246483>