Bug 198889 - [LFC][Floats] Add bottom value to FloatingState::Constraints
Summary: [LFC][Floats] Add bottom value to FloatingState::Constraints
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-15 07:14 PDT by zalan
Modified: 2019-06-16 13:15 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.08 KB, patch)
2019-06-15 07:34 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (8.57 KB, patch)
2019-06-15 08:27 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (8.57 KB, patch)
2019-06-15 12:36 PDT, zalan 		koivisto: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-06-15 07:14:18 PDT 
This is going to be used by inline layout to check where the next line is supposed to be.
Comment 1 Radar WebKit Bug Importer 2019-06-15 07:14:36 PDT 
<rdar://problem/51776730>
Comment 2 zalan 2019-06-15 07:34:40 PDT 
Created attachment 372192 [details]
Patch
Comment 3 zalan 2019-06-15 08:27:12 PDT 
Created attachment 372193 [details]
Patch
Comment 4 zalan 2019-06-15 12:36:46 PDT 
Created attachment 372198 [details]
Patch
Comment 5 Antti Koivisto 2019-06-16 12:19:15 PDT 
Comment on attachment 372198 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372198&action=review

> Source/WebCore/layout/LayoutUnits.h:63
> +    void moveBy(LayoutSize);

IntPoint calls this move. Generally it would be good to match existing interfaces unless there is a good reason not to.
Comment 6 zalan 2019-06-16 13:15:07 PDT 
Committed r246482: <https://trac.webkit.org/changeset/246482>