RESOLVED FIXED 198889
[LFC][Floats] Add bottom value to FloatingState::Constraints 
https://bugs.webkit.org/show_bug.cgi?id=198889
Summary [LFC][Floats] Add bottom value to FloatingState::Constraints
zalan
Reported 2019-06-15 07:14:18 PDT
This is going to be used by inline layout to check where the next line is supposed to be.
Attachments
Patch (4.08 KB, patch)
2019-06-15 07:34 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (8.57 KB, patch)
2019-06-15 08:27 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (8.57 KB, patch)
2019-06-15 12:36 PDT, zalan 		koivisto: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-06-15 07:14:36 PDT
<rdar://problem/51776730>
zalan
Comment 2 2019-06-15 07:34:40 PDT
Created attachment 372192 [details] Patch
zalan
Comment 3 2019-06-15 08:27:12 PDT
Created attachment 372193 [details] Patch
zalan
Comment 4 2019-06-15 12:36:46 PDT
Created attachment 372198 [details] Patch
Antti Koivisto
Comment 5 2019-06-16 12:19:15 PDT
Comment on attachment 372198 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372198&action=review > Source/WebCore/layout/LayoutUnits.h:63 > + void moveBy(LayoutSize); IntPoint calls this move. Generally it would be good to match existing interfaces unless there is a good reason not to.
zalan
Comment 6 2019-06-16 13:15:07 PDT
Committed r246482: <https://trac.webkit.org/changeset/246482>
Note You need to log in before you can comment on or make changes to this bug.