and use it instead of isDescendentOf.
<rdar://problem/51776466>
Created attachment 372191 [details] Patch
Created attachment 372197 [details] Patch
Comment on attachment 372197 [details] Patch Clearing flags on attachment: 372197 Committed r246479: <https://trac.webkit.org/changeset/246479>
All reviewed patches have been landed. Closing bug.
Given how self contained LFC is, have you consider using more traditional style unit tests in addition to layout tests? Having tests for things like Box::isDescendantOf and Box::isContainingBlockDescendantOf seem like they would map very nicely to that style of testing.
(In reply to Sam Weinig from comment #6) > Given how self contained LFC is, have you consider using more traditional > style unit tests in addition to layout tests? Having tests for things like > Box::isDescendantOf and Box::isContainingBlockDescendantOf seem like they > would map very nicely to that style of testing. No I have not thought about it yet but I think it is a great idea!!! Currently I simply match the geometries in the 2 trees after each layout frame. 1. Run RenderObject base layout 2. Run LFC layout 3. call verifyAndOutputMismatchingLayoutTree() -> assert so yeah, I should start thinking about adding some unit tests.