RESOLVED FIXED198888
[LFC] Add Layout::Box::isContainingBlockDescendantOf 
https://bugs.webkit.org/show_bug.cgi?id=198888
Summary [LFC] Add Layout::Box::isContainingBlockDescendantOf
alan
Reported 2019-06-15 06:25:25 PDT
and use it instead of isDescendentOf.
Attachments
Patch (7.32 KB, patch)
2019-06-15 06:32 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (7.32 KB, patch)
2019-06-15 12:32 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-06-15 06:25:51 PDT
<rdar://problem/51776466>
alan
Comment 2 2019-06-15 06:32:43 PDT
Created attachment 372191 [details] Patch
alan
Comment 3 2019-06-15 12:32:48 PDT
Created attachment 372197 [details] Patch
WebKit Commit Bot
Comment 4 2019-06-16 12:33:23 PDT
Comment on attachment 372197 [details] Patch Clearing flags on attachment: 372197 Committed r246479: <https://trac.webkit.org/changeset/246479>
WebKit Commit Bot
Comment 5 2019-06-16 12:33:25 PDT
All reviewed patches have been landed. Closing bug.
Sam Weinig
Comment 6 2019-06-16 12:51:43 PDT
Given how self contained LFC is, have you consider using more traditional style unit tests in addition to layout tests? Having tests for things like Box::isDescendantOf and Box::isContainingBlockDescendantOf seem like they would map very nicely to that style of testing.
alan
Comment 7 2019-06-18 07:45:35 PDT
(In reply to Sam Weinig from comment #6) > Given how self contained LFC is, have you consider using more traditional > style unit tests in addition to layout tests? Having tests for things like > Box::isDescendantOf and Box::isContainingBlockDescendantOf seem like they > would map very nicely to that style of testing. No I have not thought about it yet but I think it is a great idea!!! Currently I simply match the geometries in the 2 trees after each layout frame. 1. Run RenderObject base layout 2. Run LFC layout 3. call verifyAndOutputMismatchingLayoutTree() -> assert so yeah, I should start thinking about adding some unit tests.
Note You need to log in before you can comment on or make changes to this bug.