Bug 198881 – [LFC] Add limited quirks mode to LayoutState.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

ssia

[Radar WebKit Bug Importer]

<rdar://problem/51773229>

[zalan]

Created attachment 372181 [details]
Patch

[Sam Weinig]

Comment on attachment 372181 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372181&action=review

> Source/WebCore/layout/LayoutState.h:67
> +    void setQuirksMode(QuirksMode quirksMode) { m_quirksMode = quirksMode; }

Why not use Document's DocumentCompatibilityMode?

[zalan]

(In reply to Sam Weinig from comment #3)
> Comment on attachment 372181 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=372181&action=review
> 
> > Source/WebCore/layout/LayoutState.h:67
> > +    void setQuirksMode(QuirksMode quirksMode) { m_quirksMode = quirksMode; }
> 
> Why not use Document's DocumentCompatibilityMode?
This will definitely change in the future but right now the idea is to be as self-contained as possible.

[zalan]

(In reply to zalan from comment #4)
> (In reply to Sam Weinig from comment #3)
> > Comment on attachment 372181 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=372181&action=review
> > 
> > > Source/WebCore/layout/LayoutState.h:67
> > > +    void setQuirksMode(QuirksMode quirksMode) { m_quirksMode = quirksMode; }
> > 
> > Why not use Document's DocumentCompatibilityMode?
> This will definitely change in the future but right now the idea is to be as
> self-contained as possible.
RenderStyle is the only area where I gave up on being self-contained so far.

[zalan]

Created attachment 372221 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 372221 [details]
Patch

Clearing flags on attachment: 372221

Committed r246477: <https://trac.webkit.org/changeset/246477>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.