Bug 198881 - [LFC] Add limited quirks mode to LayoutState.
Summary: [LFC] Add limited quirks mode to LayoutState.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-15 00:33 PDT by zalan
Modified: 2019-06-16 12:30 PDT (History)
7 users (show)

See Also:


Attachments
Patch (3.72 KB, patch)
2019-06-15 00:36 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (3.70 KB, patch)
2019-06-16 08:27 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-06-15 00:33:04 PDT
ssia
Comment 1 Radar WebKit Bug Importer 2019-06-15 00:33:29 PDT
<rdar://problem/51773229>
Comment 2 zalan 2019-06-15 00:36:54 PDT
Created attachment 372181 [details]
Patch
Comment 3 Sam Weinig 2019-06-15 13:15:07 PDT
Comment on attachment 372181 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372181&action=review

> Source/WebCore/layout/LayoutState.h:67
> +    void setQuirksMode(QuirksMode quirksMode) { m_quirksMode = quirksMode; }

Why not use Document's DocumentCompatibilityMode?
Comment 4 zalan 2019-06-15 13:22:16 PDT
(In reply to Sam Weinig from comment #3)
> Comment on attachment 372181 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=372181&action=review
> 
> > Source/WebCore/layout/LayoutState.h:67
> > +    void setQuirksMode(QuirksMode quirksMode) { m_quirksMode = quirksMode; }
> 
> Why not use Document's DocumentCompatibilityMode?
This will definitely change in the future but right now the idea is to be as self-contained as possible.
Comment 5 zalan 2019-06-15 13:23:53 PDT
(In reply to zalan from comment #4)
> (In reply to Sam Weinig from comment #3)
> > Comment on attachment 372181 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=372181&action=review
> > 
> > > Source/WebCore/layout/LayoutState.h:67
> > > +    void setQuirksMode(QuirksMode quirksMode) { m_quirksMode = quirksMode; }
> > 
> > Why not use Document's DocumentCompatibilityMode?
> This will definitely change in the future but right now the idea is to be as
> self-contained as possible.
RenderStyle is the only area where I gave up on being self-contained so far.
Comment 6 zalan 2019-06-16 08:27:16 PDT
Created attachment 372221 [details]
Patch
Comment 7 WebKit Commit Bot 2019-06-16 12:30:52 PDT
Comment on attachment 372221 [details]
Patch

Clearing flags on attachment: 372221

Committed r246477: <https://trac.webkit.org/changeset/246477>
Comment 8 WebKit Commit Bot 2019-06-16 12:30:54 PDT
All reviewed patches have been landed.  Closing bug.