Bug 198875 - [MediaStream] Avoid roundoff error when setting AVCapture min/max frame rate
Summary: [MediaStream] Avoid roundoff error when setting AVCapture min/max frame rate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-14 17:40 PDT by Eric Carlson
Modified: 2019-08-21 05:17 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.01 KB, patch)
2019-06-14 19:06 PDT, Eric Carlson 		youennf: review+
Details | Formatted Diff | Diff
Patch for landing (4.97 KB, patch)
2019-06-15 19:45 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2019-06-14 17:40:23 PDT 
Avoid roundoff error when setting AVCapture min/max frame rate
Comment 1 Radar WebKit Bug Importer 2019-06-14 17:40:33 PDT 
<rdar://problem/51768374>
Comment 2 Eric Carlson 2019-06-14 19:06:26 PDT 
Created attachment 372165 [details]
Patch
Comment 3 youenn fablet 2019-06-15 18:39:18 PDT 
Comment on attachment 372165 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372165&action=review

> Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:339
> +                [device() setActiveVideoMaxFrameDuration: frameRateRange.maxFrameDuration];

Probably frameDuration instead of frameRateRange.maxFrameDuration.
Comment 4 Eric Carlson 2019-06-15 19:45:34 PDT 
Created attachment 372211 [details]
Patch for landing
Comment 5 Eric Carlson 2019-06-15 19:52:05 PDT 
Comment on attachment 372165 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372165&action=review

>> Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:339
>> +                [device() setActiveVideoMaxFrameDuration: frameRateRange.maxFrameDuration];
> 
> Probably frameDuration instead of frameRateRange.maxFrameDuration.

Oops, I uploaded an old version of the patch :-/
Comment 6 WebKit Commit Bot 2019-06-16 18:38:57 PDT 
Comment on attachment 372211 [details]
Patch for landing

Clearing flags on attachment: 372211

Committed r246489: <https://trac.webkit.org/changeset/246489>