Bug 198864 – Optimize `resolve` method lookup in Promise static methods

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Alexey Shvayka]

ECMA262: https://github.com/tc39/ecma262/pull/1506
Test262:
  # Promise.all
  https://test262.report/browse/built-ins/Promise/all/invoke-resolve-get-error-close.js
  https://test262.report/browse/built-ins/Promise/all/invoke-resolve-get-once-multiple-calls.js
  https://test262.report/browse/built-ins/Promise/all/invoke-resolve-get-once-no-calls.js

  # Promise.allSettled
  https://test262.report/browse/built-ins/Promise/allSettled/invoke-resolve-get-error-close.js
  https://test262.report/browse/built-ins/Promise/allSettled/invoke-resolve-get-once-multiple-calls.js
  https://test262.report/browse/built-ins/Promise/allSettled/invoke-resolve-get-once-no-calls.js

  # Promise.race
  https://test262.report/browse/built-ins/Promise/race/invoke-resolve-get-error-close.js
  https://test262.report/browse/built-ins/Promise/race/invoke-resolve-get-once-multiple-calls.js
  https://test262.report/browse/built-ins/Promise/race/invoke-resolve-get-once-no-calls.js

[Alexey Shvayka]

Created attachment 372138 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 372138 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 372138 [details]
Patch

Rejecting attachment 372138 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 372138, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=372138&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=198864&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 372138 from bug 198864.
Fetching: https://bugs.webkit.org/attachment.cgi?id=372138
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Yusuke Suzuki']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 4 diffs from patch file(s).
patching file JSTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file JSTests/test262/expectations.yaml
Hunk #1 FAILED at 1080.
Hunk #2 succeeded at 1110 (offset 18 lines).
1 out of 2 hunks FAILED -- saving rejects to file JSTests/test262/expectations.yaml.rej
patching file Source/JavaScriptCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/JavaScriptCore/builtins/PromiseConstructor.js

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Yusuke Suzuki']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/12523463

[Alexey Shvayka]

Created attachment 372496 [details]
Patch

Fix merge conflicts.

[Joseph Pecoraro]

Nice!

[Yusuke Suzuki]

Comment on attachment 372496 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 372496 [details]
Patch

Clearing flags on attachment: 372496

Committed r246620: <https://trac.webkit.org/changeset/246620>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/51922037>