Bug 198850 - [CMake][Win] WTF_CopyHeaders copies files everytime in incremental builds if Visual Studio generator is used
Summary: [CMake][Win] WTF_CopyHeaders copies files everytime in incremental builds if ...
Status: RESOLVED WORKSFORME
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-13 21:32 PDT by Fujii Hironori
Modified: 2019-06-27 06:50 PDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2019-06-13 21:32:35 PDT 
[CMake][Win] WTF_CopyHeaders copies files everytime in incremental builds if Visual Studio generator is used
Comment 1 Fujii Hironori 2019-06-13 21:34:40 PDT 
I'm using CMake 3.14.
Ninja generator doesn't have this issue.
Comment 2 Fujii Hironori 2019-06-13 22:11:53 PDT 
This seems Visual Studio 2019 issue.

Visual Studio 2019 16.1: NG
Visual Studio 2017 15.7.6: OK
Comment 3 Fujii Hironori 2019-06-13 22:50:54 PDT 
It seems that this issue has been fixed. But, I can't find a entry in release notes.

Visual Studio 2019 16.1.3: OK
Comment 4 Fujii Hironori 2019-06-13 23:16:51 PDT 
My coworker is still having this issue even with Visual Studio 2019 16.1.3.

Hmm, it seems that this issue can't be reproducible on my PC now.
It is irrelevant to Visual Studio versions.
Comment 5 Fujii Hironori 2019-06-27 02:48:16 PDT 
VS 2019 16.1 rebuilds add_custom_command files every time (#19303) · Issues · CMake / CMake · GitLab
https://gitlab.kitware.com/cmake/cmake/issues/19303

This issue was fixed in CMake 3.14.5.
I'm using CMake 3.14.5 (My CMake was automatically upgraded by Chocolatey).
Comment 6 Fujii Hironori 2019-06-27 06:50:03 PDT 
https://blog.kitware.com/cmake-3-14-5-available-for-download/

> The Visual Studio 2019 16.1 update introduced a regression in MSBuild’s evaluation of custom command dependencies causing them to re-run on every build. CMake 3.14.5 includes a workaround,