Bug 198844 – Cloning a MediaStreamTrack does not clone the logger

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Cloning a MediaStreamTrack does not clone the logger

[youenn fablet]

Created attachment 372082 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/51729128>

[WebKit Commit Bot]

Comment on attachment 372082 [details]
Patch

Clearing flags on attachment: 372082

Committed r246436: <https://trac.webkit.org/changeset/246436>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 372082 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372082&action=review

Oops, had a comment, but forgot to get it to you before you landed this.

> Source/WebCore/Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp:48
> +static inline Ref<const Logger> loggerFromContext(ScriptExecutionContext& context)
> +{
> +    return downcast<Document>(context).logger();
> +}

I’m not sure that a function for this is a good idea. This expression seems not much longer than the function call. I suggest just doing this work inline. It’s good to be able to see the code assuming the context is a document, I think, rather than encapsulating that in a helper.

> Source/WebCore/Modules/mediastream/MediaStream.cpp:54
> +static inline Ref<const Logger> loggerFromContext(ScriptExecutionContext& context)
> +{
> +    return downcast<Document>(context).logger();
> +}

Ditto.

[youenn fablet]

(In reply to Darin Adler from comment #5)
> Comment on attachment 372082 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=372082&action=review
> 
> Oops, had a comment, but forgot to get it to you before you landed this.
> 
> > Source/WebCore/Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp:48
> > +static inline Ref<const Logger> loggerFromContext(ScriptExecutionContext& context)
> > +{
> > +    return downcast<Document>(context).logger();
> > +}
> 
> I’m not sure that a function for this is a good idea. This expression seems
> not much longer than the function call. I suggest just doing this work
> inline. It’s good to be able to see the code assuming the context is a
> document, I think, rather than encapsulating that in a helper.
> 
> > Source/WebCore/Modules/mediastream/MediaStream.cpp:54
> > +static inline Ref<const Logger> loggerFromContext(ScriptExecutionContext& context)
> > +{
> > +    return downcast<Document>(context).logger();
> > +}
> 
> Ditto.

OK, let's make MediaStream take a Document& instead of a ScriptExecutionContext& since code is expecting that elsewhere anyway.
Filed https://bugs.webkit.org/show_bug.cgi?id=198873

[youenn fablet]

It seems we should move logger to ScriptExecutionContext since we might want to do release logging in workers, especially service workers.