Bug 198843 - Disable AppSSO for web processes and plugin processes
Summary: Disable AppSSO for web processes and plugin processes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-13 14:32 PDT by Jiewen Tan
Modified: 2019-06-14 14:39 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.40 KB, patch)
2019-06-13 14:38 PDT, Jiewen Tan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2019-06-13 14:32:24 PDT 
Disable AppSSO for web processes and plugin processes.
Comment 1 Jiewen Tan 2019-06-13 14:32:45 PDT 
<rdar://problem/51642920>
Comment 2 Jiewen Tan 2019-06-13 14:38:54 PDT 
Created attachment 372079 [details]
Patch
Comment 3 Sam Weinig 2019-06-14 11:25:13 PDT 
Comment on attachment 372079 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372079&action=review

> Source/WebKit/PluginProcess/mac/PluginProcessMac.mm:408
> +#if HAVE(LOAD_OPTIMIZER)

Why is the conditional called HAVE(LOAD_OPTIMIZER)?
Comment 4 Jiewen Tan 2019-06-14 11:56:40 PDT 
(In reply to Sam Weinig from comment #3)
> Comment on attachment 372079 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=372079&action=review
> 
> > Source/WebKit/PluginProcess/mac/PluginProcessMac.mm:408
> > +#if HAVE(LOAD_OPTIMIZER)
> 
> Why is the conditional called HAVE(LOAD_OPTIMIZER)?
Cause we are hiding some secrets in WKA. Since we are post WWDC now, my next patch after this will move the whole AppSSO thing to OpenSource.
Comment 5 Jiewen Tan 2019-06-14 14:08:17 PDT 
Comment on attachment 372079 [details]
Patch

Thanks Sam for r+ this patch.
Comment 6 WebKit Commit Bot 2019-06-14 14:39:13 PDT 
Comment on attachment 372079 [details]
Patch

Clearing flags on attachment: 372079

Committed r246446: <https://trac.webkit.org/changeset/246446>
Comment 7 WebKit Commit Bot 2019-06-14 14:39:14 PDT 
All reviewed patches have been landed.  Closing bug.