WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
198843
Disable AppSSO for web processes and plugin processes
https://bugs.webkit.org/show_bug.cgi?id=198843
Summary
Disable AppSSO for web processes and plugin processes
Jiewen Tan
Reported
2019-06-13 14:32:24 PDT
Disable AppSSO for web processes and plugin processes.
Attachments
Patch
(6.40 KB, patch)
2019-06-13 14:38 PDT
,
Jiewen Tan
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Jiewen Tan
Comment 1
2019-06-13 14:32:45 PDT
<
rdar://problem/51642920
>
Jiewen Tan
Comment 2
2019-06-13 14:38:54 PDT
Created
attachment 372079
[details]
Patch
Sam Weinig
Comment 3
2019-06-14 11:25:13 PDT
Comment on
attachment 372079
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=372079&action=review
> Source/WebKit/PluginProcess/mac/PluginProcessMac.mm:408 > +#if HAVE(LOAD_OPTIMIZER)
Why is the conditional called HAVE(LOAD_OPTIMIZER)?
Jiewen Tan
Comment 4
2019-06-14 11:56:40 PDT
(In reply to Sam Weinig from
comment #3
)
> Comment on
attachment 372079
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=372079&action=review
> > > Source/WebKit/PluginProcess/mac/PluginProcessMac.mm:408 > > +#if HAVE(LOAD_OPTIMIZER) > > Why is the conditional called HAVE(LOAD_OPTIMIZER)?
Cause we are hiding some secrets in WKA. Since we are post WWDC now, my next patch after this will move the whole AppSSO thing to OpenSource.
Jiewen Tan
Comment 5
2019-06-14 14:08:17 PDT
Comment on
attachment 372079
[details]
Patch Thanks Sam for r+ this patch.
WebKit Commit Bot
Comment 6
2019-06-14 14:39:13 PDT
Comment on
attachment 372079
[details]
Patch Clearing flags on attachment: 372079 Committed
r246446
: <
https://trac.webkit.org/changeset/246446
>
WebKit Commit Bot
Comment 7
2019-06-14 14:39:14 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug