Bug 198842 – Move Synthetic Editing Commands to behind an experimental feature flag

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Megan Gardner]

Move Synthetic Editing Commands to behind an experimental feature flag

[Megan Gardner]

Created attachment 372077 [details]
Patch

[Megan Gardner]

<rdar://problem/50594700>

[Simon Fraser (smfr)]

Comment on attachment 372077 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372077&action=review

> Source/WebCore/page/RuntimeEnabledFeatures.h:188
> +    void setSyntheticEditingCommandsEnabled(bool isEnabled) { m_syntheticEditingCommandsEnabled = isEnabled; }
> +    bool syntheticEditingCommandsEnabled() const { return m_syntheticEditingCommandsEnabled; }

Should this be Setting instead?

[Ryosuke Niwa]

Comment on attachment 372077 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372077&action=review

>> Source/WebCore/page/RuntimeEnabledFeatures.h:188
>> +    bool syntheticEditingCommandsEnabled() const { return m_syntheticEditingCommandsEnabled; }
> 
> Should this be Setting instead?

Probably. There is no reason this needs to be enabled across the process.

[Megan Gardner]

Created attachment 372081 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 372081 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372081&action=review

Now this is a setting, you can write tests for it (if we have the plumbing).

> Source/WebKitLegacy/mac/WebView/WebView.mm:3165
> +    RuntimeEnabledFeatures::sharedFeatures().setSyntheticEditingCommandsEnabled([preferences syntheticEditingCommandsEnabled]);

Nope!

[Megan Gardner]

Created attachment 372087 [details]
Patch

[Megan Gardner]

Created attachment 372137 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 372137 [details]
Patch for landing

Clearing flags on attachment: 372137

Committed r246444: <https://trac.webkit.org/changeset/246444>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.