WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
198835
[iOS] Normalize test result of fast/events/ios/keyboard-event-key-attribute.html to handle possible modifier dispatch
https://bugs.webkit.org/show_bug.cgi?id=198835
Summary
[iOS] Normalize test result of fast/events/ios/keyboard-event-key-attribute.h...
Daniel Bates
Reported
2019-06-13 10:16:58 PDT
In the future, modifier keys like Shift will be dispatched on iOS (just like they are on Mac). Prepare fast/events/ios/keyboard-event-key-attribute.html for this future by normalizing its results. This test types '@' which requires holding down Shift to type on a US keyboard layout, but only expects to see a keydown for '@'. Currently, we only dispatch a keydown for the '@'. In the future, we will dispatch a keydown for Shift followed by a keydown for '@'.
Attachments
Patch
(2.27 KB, patch)
2019-06-13 10:23 PDT
,
Daniel Bates
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Daniel Bates
Comment 1
2019-06-13 10:17:01 PDT
<
rdar://problem/46082708
>
Daniel Bates
Comment 2
2019-06-13 10:23:08 PDT
Created
attachment 372065
[details]
Patch
Daniel Bates
Comment 3
2019-06-13 16:02:01 PDT
Comment on
attachment 372065
[details]
Patch Clearing flags on attachment: 372065 Committed
r246417
: <
https://trac.webkit.org/changeset/246417
>
Daniel Bates
Comment 4
2019-06-13 16:02:02 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug