Bug 198835 - [iOS] Normalize test result of fast/events/ios/keyboard-event-key-attribute.html to handle possible modifier dispatch
Summary: [iOS] Normalize test result of fast/events/ios/keyboard-event-key-attribute.h...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: iPhone / iPad iOS 12
: P2 Normal
Assignee: Daniel Bates
Keywords: InRadar
Depends on:
Reported: 2019-06-13 10:16 PDT by Daniel Bates
Modified: 2019-06-13 16:02 PDT (History)
3 users (show)

See Also:

Patch (2.27 KB, patch)
2019-06-13 10:23 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2019-06-13 10:16:58 PDT
In the future, modifier keys like Shift will be dispatched on iOS (just like they are on Mac). Prepare fast/events/ios/keyboard-event-key-attribute.html  for this future by normalizing its results. This test types '@' which requires holding down Shift to type on a US keyboard layout, but only expects to see a keydown for '@'. Currently, we only dispatch a keydown for the '@'. In the future, we will dispatch a keydown for Shift followed by a keydown for '@'.
Comment 1 Daniel Bates 2019-06-13 10:17:01 PDT
Comment 2 Daniel Bates 2019-06-13 10:23:08 PDT
Created attachment 372065 [details]
Comment 3 Daniel Bates 2019-06-13 16:02:01 PDT
Comment on attachment 372065 [details]

Clearing flags on attachment: 372065

Committed r246417: <https://trac.webkit.org/changeset/246417>
Comment 4 Daniel Bates 2019-06-13 16:02:02 PDT
All reviewed patches have been landed.  Closing bug.