Bug 198832 – twitch.tv: embedded video hovers down the screen when scrolling on iPad

• Status: RESOLVED
• Resolution: FIXED
• Component: Scrolling

[Antti Koivisto]

It does.

[Antti Koivisto]

<rdar://problem/51541439>

[Antti Koivisto]

Created attachment 372056 [details]
patch

[Geoffrey Garen]

Comment on attachment 372056 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372056&action=review

> Source/WebCore/rendering/RenderLayer.cpp:2522
> +                if (auto* paintParent = paintOrderParent())
> +                    paintParent->setDescendantsNeedUpdateBackingAndHierarchyTraversal();

This might be a stupid question, but... In the case where paintParent is null, shouldn't we still setDescendantsNeedUpdateBackingAndHierarchyTraversal() on ourselves?

auto* layer = paintOrderParent() ? paintOrderParent() : this;
layer->setDescendantsNeedUpdateBackingAndHierarchyTraversal();

[Antti Koivisto]

I believe that case is impossible and that if() is just being overly defensive.

[Simon Fraser (smfr)]

Comment on attachment 372056 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372056&action=review

>> Source/WebCore/rendering/RenderLayer.cpp:2522
>> +                    paintParent->setDescendantsNeedUpdateBackingAndHierarchyTraversal();
> 
> This might be a stupid question, but... In the case where paintParent is null, shouldn't we still setDescendantsNeedUpdateBackingAndHierarchyTraversal() on ourselves?
> 
> auto* layer = paintOrderParent() ? paintOrderParent() : this;
> layer->setDescendantsNeedUpdateBackingAndHierarchyTraversal();

paintOrderParent() is only null for RenderView, so that should never hit this code.

[WebKit Commit Bot]

Comment on attachment 372056 [details]
patch

Clearing flags on attachment: 372056

Committed r246407: <https://trac.webkit.org/changeset/246407>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.