WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
198822
[GTK] gdk_display_get_device_manager and gdk_screen_get_width/height are deprecated
https://bugs.webkit.org/show_bug.cgi?id=198822
Summary
[GTK] gdk_display_get_device_manager and gdk_screen_get_width/height are depr...
Ludovico de Nittis
Reported
2019-06-13 03:20:08 PDT
Since GTK 3.20 gdk_display_get_device_manager has been deprecated. Since GTK 3.22 gdk_screen_get_width and gdk_screen_get_height has been deprecated. I'm going to upload a patch. The two deprecation are not related (is only that they are both used in the same GtkVersioning.c file), but this is a small patch so I decided to go with a single commit. Let me know if you prefer two separated commits.
Attachments
Patch
(5.50 KB, patch)
2019-06-13 03:27 PDT
,
Ludovico de Nittis
no flags
Details
Formatted Diff
Diff
Patch
(5.48 KB, patch)
2019-06-13 03:51 PDT
,
Ludovico de Nittis
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Ludovico de Nittis
Comment 1
2019-06-13 03:27:04 PDT
Created
attachment 372043
[details]
Patch
Carlos Garcia Campos
Comment 2
2019-06-13 03:42:38 PDT
Comment on
attachment 372043
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=372043&action=review
> Source/WebCore/platform/gtk/GtkVersioning.c:35 > + GdkSeat *seat = gdk_display_get_default_seat(gdk_window_get_display(window)); > + return gdk_seat_get_pointer(seat);
return gdk_seat_get_pointer(gdk_display_get_default_seat(gdk_window_get_display(window)));
Ludovico de Nittis
Comment 3
2019-06-13 03:51:24 PDT
Created
attachment 372045
[details]
Patch
WebKit Commit Bot
Comment 4
2019-06-13 04:38:51 PDT
Comment on
attachment 372045
[details]
Patch Clearing flags on attachment: 372045 Committed
r246398
: <
https://trac.webkit.org/changeset/246398
>
WebKit Commit Bot
Comment 5
2019-06-13 04:38:53 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug