:(
Created attachment 371985 [details] Patch
Comment on attachment 371985 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371985&action=review > Source/WebCore/inspector/InspectorFrontendHost.cpp:431 > auto& mouseEvent = downcast<MouseEvent>(event); > + > IntPoint mousePoint { mouseEvent.clientX(), mouseEvent.clientY() }; > + mousePoint.scale(zoomFactor()); Seems fine, but is there a better way to get the mouse position of zoomed content? MouseRelatedEvent.h has: // Page point in "absolute" coordinates (i.e. post-zoomed, page-relative coords, // usable with RenderObject::absoluteToLocal). const LayoutPoint& absoluteLocation() const { return m_absoluteLocation; } That ultimately uses: float FrameView::documentToAbsoluteScaleFactor(Optional<float> effectiveZoom) const { // If effectiveZoom is passed, it already factors in pageZoomFactor(). return effectiveZoom.valueOr(frame().pageZoomFactor()) * frame().frameScaleFactor(); } As opposed to the current `InspectorFrontendHost::zoomFactor()` which only does the page zoom: m_frontendPage->mainFrame().pageZoomFactor(); So, what is `frameScaleFactor` and what is that / should that be taken into account here?
Comment on attachment 371985 [details] Patch r=me though since this can't be worse then what we currently have
Created attachment 371991 [details] Patch
Comment on attachment 371991 [details] Patch Clearing flags on attachment: 371991 Committed r246384: <https://trac.webkit.org/changeset/246384>
All reviewed patches have been landed. Closing bug.
<rdar://problem/51686539>
*** Bug 195759 has been marked as a duplicate of this bug. ***