Bug 198801 – Web Inspector: artificial context menus don't work when Web Inspector is zoomed

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

:(

[Devin Rousso]

Created attachment 371985 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 371985 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371985&action=review

> Source/WebCore/inspector/InspectorFrontendHost.cpp:431
>      auto& mouseEvent = downcast<MouseEvent>(event);
> +
>      IntPoint mousePoint { mouseEvent.clientX(), mouseEvent.clientY() };
> +    mousePoint.scale(zoomFactor());

Seems fine, but is there a better way to get the mouse position of zoomed content?

MouseRelatedEvent.h has:

    // Page point in "absolute" coordinates (i.e. post-zoomed, page-relative coords,
    // usable with RenderObject::absoluteToLocal).
    const LayoutPoint& absoluteLocation() const { return m_absoluteLocation; }

That ultimately uses:

    float FrameView::documentToAbsoluteScaleFactor(Optional<float> effectiveZoom) const
    {
        // If effectiveZoom is passed, it already factors in pageZoomFactor(). 
        return effectiveZoom.valueOr(frame().pageZoomFactor()) * frame().frameScaleFactor();
    }

As opposed to the current `InspectorFrontendHost::zoomFactor()` which only does the page zoom:

    m_frontendPage->mainFrame().pageZoomFactor();

So, what is `frameScaleFactor` and what is that / should that be taken into account here?

[Joseph Pecoraro]

Comment on attachment 371985 [details]
Patch

r=me though since this can't be worse then what we currently have

[Devin Rousso]

Created attachment 371991 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 371991 [details]
Patch

Clearing flags on attachment: 371991

Committed r246384: <https://trac.webkit.org/changeset/246384>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/51686539>

[Devin Rousso]

*** Bug 195759 has been marked as a duplicate of this bug. ***