Bug 198800 - REGRESSION (r246103) [ Mojave+ WK1 ] Layout Test scrollbars/scrollbar-iframe-click-does-not-blur-content.html is timing out
Summary: REGRESSION (r246103) [ Mojave+ WK1 ] Layout Test scrollbars/scrollbar-iframe-...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
Keywords: InRadar
Depends on:
Reported: 2019-06-12 13:14 PDT by Shawn Roberts
Modified: 2019-06-13 23:51 PDT (History)
5 users (show)

See Also:

Patch (9.40 KB, patch)
2019-06-13 03:11 PDT, Antoine Quint
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shawn Roberts 2019-06-12 13:14:35 PDT
The following layout test is failing on Mojave+ WK1


Probable cause:

After changes in r246103 the the above layout test is timing out every run on WK1 testers

Flakiness Dashboard:

Comment 1 Radar WebKit Bug Importer 2019-06-12 13:15:25 PDT
Comment 2 Shawn Roberts 2019-06-12 13:22:17 PDT
Updated expectations in https://trac.webkit.org/changeset/246371/webkit
Comment 3 Antoine Quint 2019-06-13 02:58:48 PDT
We don't detect an NSScroller in a sub-frame due to the WebHTMLView's implementation of -[NSView hitTest:]. We need to use the real method when detecting which view we're trying to swizzle the event for.
Comment 4 Antoine Quint 2019-06-13 03:11:56 PDT
Created attachment 372042 [details]
Comment 5 Tim Horton 2019-06-13 10:36:34 PDT
Comment on attachment 372042 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=372042&action=review

> Tools/ChangeLog:10
> +        which lets use use the default implementation and correctly returns an NSScroller in a sub-frame.

use use

> Tools/DumpRenderTree/mac/EventSendingController.mm:570
> +        view = [(WebHTMLView*)view _hitViewForEvent:event];

WebHTMLView *
Comment 6 Antoine Quint 2019-06-13 23:51:01 PDT
Committed r246429: <https://trac.webkit.org/changeset/246429>