Bug 198800 – REGRESSION (r246103) [ Mojave+ WK1 ] Layout Test scrollbars/scrollbar-iframe-click-does-not-blur-content.html is timing out

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Shawn Roberts]

The following layout test is failing on Mojave+ WK1

scrollbars/scrollbar-iframe-click-does-not-blur-content.html

Probable cause:

After changes in r246103 the the above layout test is timing out every run on WK1 testers

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=scrollbars%2Fscrollbar-iframe-click-does-not-blur-content.html

[Radar WebKit Bug Importer]

<rdar://problem/51679634>

[Shawn Roberts]

Updated expectations in https://trac.webkit.org/changeset/246371/webkit

[Antoine Quint]

We don't detect an NSScroller in a sub-frame due to the WebHTMLView's implementation of -[NSView hitTest:]. We need to use the real method when detecting which view we're trying to swizzle the event for.

[Antoine Quint]

Created attachment 372042 [details]
Patch

[Tim Horton]

Comment on attachment 372042 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372042&action=review

> Tools/ChangeLog:10
> +        which lets use use the default implementation and correctly returns an NSScroller in a sub-frame.

use use

> Tools/DumpRenderTree/mac/EventSendingController.mm:570
> +        view = [(WebHTMLView*)view _hitViewForEvent:event];

WebHTMLView *

[Antoine Quint]

Committed r246429: <https://trac.webkit.org/changeset/246429>