Bug 198799 – [iOS] Adjust tests platform/ipad/fast/forms/{select-form-run-twice, unfocus-inside-fixed-hittest}.html following r243808

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Daniel Bates]

Following r243808 (bug #196272) we no longer defocus a <select> on iPad when its popover is dismissed as a result of picking a value for it. This is to make behavior of <select> on iPad like the Mac. We need to update the tests platform/ipad/fast/forms/{select-form-run-twice, unfocus-inside-fixed-hittest}.html to not expect the defocusing of the <select>, which they observe by way of registering for a uiController.didEndFormControlInteractionCallback callback.

[Daniel Bates]

<rdar://problem/50181023>

[Daniel Bates]

Created attachment 371982 [details]
Patch

[Brent Fulgham]

Comment on attachment 371982 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371982&action=review

> LayoutTests/platform/ipad/fast/forms/select-form-run-twice.html:56
> +                        uiController.uiScriptComplete()

Nit: Semicolon at end of statement.

[Daniel Bates]

(In reply to Brent Fulgham from comment #3)
> Comment on attachment 371982 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=371982&action=review
> 
> > LayoutTests/platform/ipad/fast/forms/select-form-run-twice.html:56
> > +                        uiController.uiScriptComplete()
> 
> Nit: Semicolon at end of statement.

It's JavaScript. Automatic semicolon insertion applies 😀 <-- seriously, this is language feature. I'll add the semicolon just because I like the aesthetics.

[Daniel Bates]

Created attachment 371996 [details]
To land

[Daniel Bates]

Committed r246386: <https://trac.webkit.org/changeset/246386>