WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
198791
[Nicosia] Add SceneIntegration
https://bugs.webkit.org/show_bug.cgi?id=198791
Summary
[Nicosia] Add SceneIntegration
Zan Dobersek
Reported
2019-06-12 09:11:40 PDT
[Nicosia] Add SceneIntegration
Attachments
WIP
(18.58 KB, patch)
2019-06-12 09:13 PDT
,
Zan Dobersek
no flags
Details
Formatted Diff
Diff
Patch
(19.87 KB, patch)
2019-06-12 13:47 PDT
,
Zan Dobersek
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews211 for win-future
(13.98 MB, application/zip)
2019-06-12 17:31 PDT
,
EWS Watchlist
no flags
Details
Patch for landing
(20.05 KB, patch)
2019-06-13 06:57 PDT
,
Zan Dobersek
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Zan Dobersek
Comment 1
2019-06-12 09:13:46 PDT
Created
attachment 371965
[details]
WIP
EWS Watchlist
Comment 2
2019-06-12 09:17:40 PDT
Attachment 371965
[details]
did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Zan Dobersek
Comment 3
2019-06-12 13:47:44 PDT
Created
attachment 371983
[details]
Patch
EWS Watchlist
Comment 4
2019-06-12 17:31:02 PDT
Comment on
attachment 371983
[details]
Patch
Attachment 371983
[details]
did not pass win-ews (win): Output:
https://webkit-queues.webkit.org/results/12458738
New failing tests: imported/blink/fast/canvas/canvas-clip-stack-persistence.html svg/text/textpath-reference-update.html fast/shadow-dom/svg-thref-href-change-in-shadow-tree.html css3/filters/blur-various-radii.html imported/blink/fast/canvas/bug382588.html storage/indexeddb/modern/get-keyrange.html
EWS Watchlist
Comment 5
2019-06-12 17:31:06 PDT
Created
attachment 372007
[details]
Archive of layout-test-results from ews211 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews211 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Carlos Garcia Campos
Comment 6
2019-06-13 04:53:20 PDT
Comment on
attachment 371983
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=371983&action=review
> Source/WebCore/platform/graphics/nicosia/NicosiaSceneIntegration.h:47 > + SceneIntegration();
Why is this needed?
> Source/WebCore/platform/graphics/nicosia/NicosiaSceneIntegration.h:48 > + SceneIntegration(Client&);
explicit
> Source/WebCore/platform/graphics/nicosia/NicosiaSceneIntegration.h:59 > + UpdateScope(Ref<SceneIntegration>&&);
explicit
> Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp:56 > + , m_sceneIntegration(*new Nicosia::SceneIntegration(*this))
I would add a Nicosia::SceneIntegration::create method returning a Ref
> Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h:44 > +#if USE(COORDINATED_GRAPHICS) > +#include <WebCore/NicosiaSceneIntegration.h> > +#endif
If NicosiaSceneIntegration is specific to COORDINATED_GRAPHICS I would move the guard to the header instead (and the cpp)
Zan Dobersek
Comment 7
2019-06-13 06:04:28 PDT
Comment on
attachment 371983
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=371983&action=review
>> Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h:44 >> +#endif > > If NicosiaSceneIntegration is specific to COORDINATED_GRAPHICS I would move the guard to the header instead (and the cpp)
It's not, but it is only used in this class if USE(COORDINATED_GRAPHICS) is enabled.
Zan Dobersek
Comment 8
2019-06-13 06:57:39 PDT
Created
attachment 372048
[details]
Patch for landing
Zan Dobersek
Comment 9
2019-06-13 07:05:41 PDT
Comment on
attachment 372048
[details]
Patch for landing Clearing flags on attachment: 372048 Committed
r246400
: <
https://trac.webkit.org/changeset/246400
>
Zan Dobersek
Comment 10
2019-06-13 07:05:45 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11
2019-06-13 07:06:22 PDT
<
rdar://problem/51706849
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug