[Nicosia] Add SceneIntegration
Created attachment 371965 [details] WIP
Attachment 371965 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 371983 [details] Patch
Comment on attachment 371983 [details] Patch Attachment 371983 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12458738 New failing tests: imported/blink/fast/canvas/canvas-clip-stack-persistence.html svg/text/textpath-reference-update.html fast/shadow-dom/svg-thref-href-change-in-shadow-tree.html css3/filters/blur-various-radii.html imported/blink/fast/canvas/bug382588.html storage/indexeddb/modern/get-keyrange.html
Created attachment 372007 [details] Archive of layout-test-results from ews211 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews211 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment on attachment 371983 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371983&action=review > Source/WebCore/platform/graphics/nicosia/NicosiaSceneIntegration.h:47 > + SceneIntegration(); Why is this needed? > Source/WebCore/platform/graphics/nicosia/NicosiaSceneIntegration.h:48 > + SceneIntegration(Client&); explicit > Source/WebCore/platform/graphics/nicosia/NicosiaSceneIntegration.h:59 > + UpdateScope(Ref<SceneIntegration>&&); explicit > Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp:56 > + , m_sceneIntegration(*new Nicosia::SceneIntegration(*this)) I would add a Nicosia::SceneIntegration::create method returning a Ref > Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h:44 > +#if USE(COORDINATED_GRAPHICS) > +#include <WebCore/NicosiaSceneIntegration.h> > +#endif If NicosiaSceneIntegration is specific to COORDINATED_GRAPHICS I would move the guard to the header instead (and the cpp)
Comment on attachment 371983 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371983&action=review >> Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h:44 >> +#endif > > If NicosiaSceneIntegration is specific to COORDINATED_GRAPHICS I would move the guard to the header instead (and the cpp) It's not, but it is only used in this class if USE(COORDINATED_GRAPHICS) is enabled.
Created attachment 372048 [details] Patch for landing
Comment on attachment 372048 [details] Patch for landing Clearing flags on attachment: 372048 Committed r246400: <https://trac.webkit.org/changeset/246400>
All reviewed patches have been landed. Closing bug.
<rdar://problem/51706849>