Bug 19879 – Inspector should support monitorEvents/un monitorEvents() in the command line

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Keishi Hattori]

Inspector should support monitorEvents/un monitorEvents() in the command line for Firebug parity.

[Adam Roben (:aroben)]

<rdar://problem/6070235>

[Keishi Hattori]

Created attachment 41089 [details]
proposed patch

Consecutive events are not shown because of bug #30324
https://bugs.webkit.org/show_bug.cgi?id=30324

Usage:
monitorEvent(el) will log all events to el
monitorEvent(el, "click") will log "click" events
monitorEvent(el, ["keydown", "keyup"]) will log "keyup" and "keydown" events
monitorEvent(el, "mouse") will log all mouse related events
monitorEvent(el, "key") will log all key related events
unmonitorEvent(el) will turn off logging for all events

[Pavel Feldman]

Comment on attachment 41089 [details]
proposed patch

> +                if (t[i] == \"mouse\") \

Use ===


> +                    te = te.concat([\"mousedown\", \"mouseup\", \"click\", \"dblclick\", \

Use splice instead in order not to create new array instances.

> +                if (t[i] == \"key\") \

Use ===


> +                o.removeEventListener

Should you test for addEventListener / removeEvent listener on an object?
Does monitorEvent(null) provide meaningful feedback well?

Other than that r+.

[Keishi Hattori]

Created attachment 41545 [details]
proposed patch 2

(In reply to comment #3)
> > +                if (t[i] == \"mouse\") \
Fixed.
> > +                    te = te.concat([\"mousedown\", \"mouseup\", \"click\", \"dblclick\", \
Fixed.
> > +                if (t[i] == \"key\") \
Fixed.
> Should you test for addEventListener / removeEvent listener on an object?
Added tests.
> Does monitorEvent(null) provide meaningful feedback well?
I wasn't sure what to do. Should it print usage help or an error?

[Pavel Feldman]

Comment on attachment 41545 [details]
proposed patch 2

FYI: we are currently working on TimelineAgent that is getting information from the instrumentation all over WebCore. Including the events. So it is already getting all the data you are collecting here. It is not bound to any particular object though, so it is a bit different, but still close!

[WebKit Commit Bot]

Comment on attachment 41545 [details]
proposed patch 2

Clearing flags on attachment: 41545

Committed r49940: <http://trac.webkit.org/changeset/49940>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.