Bug 198785 - [GTK] gtk_misc_set_alignment is deprecated since GTK 3.14
Summary: [GTK] gtk_misc_set_alignment is deprecated since GTK 3.14
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-12 06:14 PDT by Ludovico de Nittis
Modified: 2019-06-12 07:09 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.65 KB, patch)
2019-06-12 06:16 PDT, Ludovico de Nittis 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ludovico de Nittis 2019-06-12 06:14:18 PDT 
Since GTK 3.14 "gtk_misc_set_alignment" has been deprecated.

"gtk_widget_set_halign" and "gtk_widget_set_valign" should be used instead, both available since GTK 3.

I'll attach a patch.
Comment 1 Ludovico de Nittis 2019-06-12 06:16:42 PDT 
Created attachment 371947 [details]
Patch
Comment 2 EWS Watchlist 2019-06-12 06:19:14 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 WebKit Commit Bot 2019-06-12 07:09:15 PDT 
Comment on attachment 371947 [details]
Patch

Clearing flags on attachment: 371947

Committed r246351: <https://trac.webkit.org/changeset/246351>
Comment 4 WebKit Commit Bot 2019-06-12 07:09:17 PDT 
All reviewed patches have been landed.  Closing bug.