Bug 198769 - Flash when tapping compose button after switching to/from dark mode without restarting Mail
Summary: Flash when tapping compose button after switching to/from dark mode without r...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-11 15:54 PDT by Timothy Hatcher
Modified: 2019-06-11 17:44 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.56 KB, patch)
2019-06-11 16:03 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Patch (4.98 KB, patch)
2019-06-11 16:21 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Patch (4.97 KB, patch)
2019-06-11 16:22 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Patch (4.98 KB, patch)
2019-06-11 16:34 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Patch (4.98 KB, patch)
2019-06-11 16:43 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2019-06-11 15:54:22 PDT 
After switching to/from dark mode and the compose button is tapped in Mail, there is a white flash which can be seen consistently.

<rdar://problem/51370037>
Comment 1 Timothy Hatcher 2019-06-11 16:03:54 PDT Comment hidden (obsolete)
Comment 2 Tim Horton 2019-06-11 16:07:36 PDT 
Comment on attachment 371889 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371889&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:144
> +#import "LocalCurrentTraitCollection.h"

iOS API Test EWS doesn't seem to find this.... is it in WebCore?
Comment 3 Timothy Hatcher 2019-06-11 16:18:00 PDT 
Comment on attachment 371889 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371889&action=review

>> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:144
>> +#import "LocalCurrentTraitCollection.h"
> 
> iOS API Test EWS doesn't seem to find this.... is it in WebCore?

Yep… it is in WebCore now. I buggered change this when I moved it from WebKitAdditions. It built locally somehow… maybe some stale version in my search path?

Will fix.
Comment 4 Timothy Hatcher 2019-06-11 16:21:07 PDT Comment hidden (obsolete)
Comment 5 Timothy Hatcher 2019-06-11 16:22:08 PDT Comment hidden (obsolete)
Comment 6 Timothy Hatcher 2019-06-11 16:34:34 PDT Comment hidden (obsolete)
Comment 7 Timothy Hatcher 2019-06-11 16:43:09 PDT 
Created attachment 371897 [details]
Patch
Comment 8 WebKit Commit Bot 2019-06-11 17:44:47 PDT 
Comment on attachment 371897 [details]
Patch

Clearing flags on attachment: 371897

Committed r246343: <https://trac.webkit.org/changeset/246343>
Comment 9 WebKit Commit Bot 2019-06-11 17:44:48 PDT 
All reviewed patches have been landed.  Closing bug.