RESOLVED FIXED 198769
Flash when tapping compose button after switching to/from dark mode without restarting Mail 
https://bugs.webkit.org/show_bug.cgi?id=198769
Summary Flash when tapping compose button after switching to/from dark mode without r...
Timothy Hatcher
Reported 2019-06-11 15:54:22 PDT
After switching to/from dark mode and the compose button is tapped in Mail, there is a white flash which can be seen consistently. <rdar://problem/51370037>
Attachments
Patch (2.56 KB, patch)
2019-06-11 16:03 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Patch (4.98 KB, patch)
2019-06-11 16:21 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Patch (4.97 KB, patch)
2019-06-11 16:22 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Patch (4.98 KB, patch)
2019-06-11 16:34 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Patch (4.98 KB, patch)
2019-06-11 16:43 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2019-06-11 16:03:54 PDT Comment hidden (obsolete)
Tim Horton
Comment 2 2019-06-11 16:07:36 PDT
Comment on attachment 371889 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371889&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:144 > +#import "LocalCurrentTraitCollection.h" iOS API Test EWS doesn't seem to find this.... is it in WebCore?
Timothy Hatcher
Comment 3 2019-06-11 16:18:00 PDT
Comment on attachment 371889 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371889&action=review >> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:144 >> +#import "LocalCurrentTraitCollection.h" > > iOS API Test EWS doesn't seem to find this.... is it in WebCore? Yep… it is in WebCore now. I buggered change this when I moved it from WebKitAdditions. It built locally somehow… maybe some stale version in my search path? Will fix.
Timothy Hatcher
Comment 4 2019-06-11 16:21:07 PDT Comment hidden (obsolete)
Timothy Hatcher
Comment 5 2019-06-11 16:22:08 PDT Comment hidden (obsolete)
Timothy Hatcher
Comment 6 2019-06-11 16:34:34 PDT Comment hidden (obsolete)
Timothy Hatcher
Comment 7 2019-06-11 16:43:09 PDT
Created attachment 371897 [details] Patch
WebKit Commit Bot
Comment 8 2019-06-11 17:44:47 PDT
Comment on attachment 371897 [details] Patch Clearing flags on attachment: 371897 Committed r246343: <https://trac.webkit.org/changeset/246343>
WebKit Commit Bot
Comment 9 2019-06-11 17:44:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.