Bug 198768 - [iOS] Adjust test fast/events/ios/keyup.html to ignore Shift keyups
Summary: [iOS] Adjust test fast/events/ios/keyup.html to ignore Shift keyups
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: All iOS 12
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-11 15:11 PDT by Daniel Bates
Modified: 2019-06-11 16:01 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.02 KB, patch)
2019-06-11 15:13 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
To land (2.02 KB, patch)
2019-06-11 16:00 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2019-06-11 15:11:47 PDT 
In the future WebKit will receive flag changes (e.g. the Shift key was pressed). When this happens the test fast/events/ios/keyup.html will fail due to additional Shift keyup events. Fix up the test to ignore Shift keyups. We have other tests that cover the Shift keyups that will be enabled in the future.
Comment 1 Daniel Bates 2019-06-11 15:12:01 PDT 
<rdar://problem/46082743>
Comment 2 Daniel Bates 2019-06-11 15:13:47 PDT 
Created attachment 371885 [details]
Patch
Comment 3 Brent Fulgham 2019-06-11 15:56:13 PDT 
Comment on attachment 371885 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371885&action=review

> LayoutTests/ChangeLog:10
> +        currently skipped in OpenSource that will be unskipped in the future once UIKit support is available. 

Is there a radar we can reference for the UIKit update?
Comment 4 Daniel Bates 2019-06-11 15:59:31 PDT 
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 371885 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=371885&action=review
> 
> > LayoutTests/ChangeLog:10
> > +        currently skipped in OpenSource that will be unskipped in the future once UIKit support is available. 
> 
> Is there a radar we can reference for the UIKit update?

It would take me time to track them down and there is likely more than one. Short answer once we start building with ENABLE(FULL_KEYBOARD_ACCESS) in OpenSource then the time will be right to unkip many tests. Will update ChangeLog before landing.
Comment 5 Daniel Bates 2019-06-11 16:00:35 PDT 
Created attachment 371888 [details]
To land
Comment 6 Daniel Bates 2019-06-11 16:01:04 PDT 
Committed r246338: <https://trac.webkit.org/changeset/246338>