Bug 198768 – [iOS] Adjust test fast/events/ios/keyup.html to ignore Shift keyups

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Daniel Bates]

In the future WebKit will receive flag changes (e.g. the Shift key was pressed). When this happens the test fast/events/ios/keyup.html will fail due to additional Shift keyup events. Fix up the test to ignore Shift keyups. We have other tests that cover the Shift keyups that will be enabled in the future.

[Daniel Bates]

<rdar://problem/46082743>

[Daniel Bates]

Created attachment 371885 [details]
Patch

[Brent Fulgham]

Comment on attachment 371885 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371885&action=review

> LayoutTests/ChangeLog:10
> +        currently skipped in OpenSource that will be unskipped in the future once UIKit support is available. 

Is there a radar we can reference for the UIKit update?

[Daniel Bates]

(In reply to Brent Fulgham from comment #3)
> Comment on attachment 371885 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=371885&action=review
> 
> > LayoutTests/ChangeLog:10
> > +        currently skipped in OpenSource that will be unskipped in the future once UIKit support is available. 
> 
> Is there a radar we can reference for the UIKit update?

It would take me time to track them down and there is likely more than one. Short answer once we start building with ENABLE(FULL_KEYBOARD_ACCESS) in OpenSource then the time will be right to unkip many tests. Will update ChangeLog before landing.

[Daniel Bates]

Created attachment 371888 [details]
To land

[Daniel Bates]

Committed r246338: <https://trac.webkit.org/changeset/246338>