Bug 198767 - Integrate scrollbar gestures for iOS
Summary: Integrate scrollbar gestures for iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-11 14:12 PDT by Megan Gardner
Modified: 2019-06-13 01:51 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.05 KB, patch)
2019-06-11 14:13 PDT, Megan Gardner
wenson_hsieh: review+
Details | Formatted Diff | Diff
Patch (2.94 KB, patch)
2019-06-11 15:01 PDT, Megan Gardner
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2019-06-11 14:12:11 PDT
Integrate scrollbar gestures for iOS
Comment 1 Megan Gardner 2019-06-11 14:13:06 PDT
Created attachment 371878 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2019-06-11 14:28:50 PDT
<rdar://problem/51640249>
Comment 3 Wenson Hsieh 2019-06-11 14:40:40 PDT
Comment on attachment 371878 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371878&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1758
> +static BOOL _WKGestureRecognizerIsBuiltInScrollViewGestureRecognizer(UIGestureRecognizer *recognizer)

Nit - isBuiltInScrollViewGestureRecognizer()?

We typically only put a WK or _WK prefix on API or SPI.
Comment 4 Tim Horton 2019-06-11 14:42:28 PDT
Comment on attachment 371878 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371878&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1758
> +static BOOL _WKGestureRecognizerIsBuiltInScrollViewGestureRecognizer(UIGestureRecognizer *recognizer)

drop the _WK. Probably just "isBuiltInScrollViewGestureRecognizer", even.

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1771
> +    BOOL conflictsWithBuiltInGesture = _WKGestureRecognizerIsBuiltInScrollViewGestureRecognizer(preventedGestureRecognizer);

I don't think "conflictsWith" is the right phrasing?
Comment 5 Megan Gardner 2019-06-11 15:01:33 PDT
Created attachment 371883 [details]
Patch
Comment 6 WebKit Commit Bot 2019-06-11 17:24:15 PDT
Comment on attachment 371883 [details]
Patch

Clearing flags on attachment: 371883

Committed r246342: <https://trac.webkit.org/changeset/246342>