WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
198767
Integrate scrollbar gestures for iOS
https://bugs.webkit.org/show_bug.cgi?id=198767
Summary
Integrate scrollbar gestures for iOS
Megan Gardner
Reported
2019-06-11 14:12:11 PDT
Integrate scrollbar gestures for iOS
Attachments
Patch
(3.05 KB, patch)
2019-06-11 14:13 PDT
,
Megan Gardner
wenson_hsieh
: review+
Details
Formatted Diff
Diff
Patch
(2.94 KB, patch)
2019-06-11 15:01 PDT
,
Megan Gardner
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Megan Gardner
Comment 1
2019-06-11 14:13:06 PDT
Created
attachment 371878
[details]
Patch
Radar WebKit Bug Importer
Comment 2
2019-06-11 14:28:50 PDT
<
rdar://problem/51640249
>
Wenson Hsieh
Comment 3
2019-06-11 14:40:40 PDT
Comment on
attachment 371878
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=371878&action=review
> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1758 > +static BOOL _WKGestureRecognizerIsBuiltInScrollViewGestureRecognizer(UIGestureRecognizer *recognizer)
Nit - isBuiltInScrollViewGestureRecognizer()? We typically only put a WK or _WK prefix on API or SPI.
Tim Horton
Comment 4
2019-06-11 14:42:28 PDT
Comment on
attachment 371878
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=371878&action=review
> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1758 > +static BOOL _WKGestureRecognizerIsBuiltInScrollViewGestureRecognizer(UIGestureRecognizer *recognizer)
drop the _WK. Probably just "isBuiltInScrollViewGestureRecognizer", even.
> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1771 > + BOOL conflictsWithBuiltInGesture = _WKGestureRecognizerIsBuiltInScrollViewGestureRecognizer(preventedGestureRecognizer);
I don't think "conflictsWith" is the right phrasing?
Megan Gardner
Comment 5
2019-06-11 15:01:33 PDT
Created
attachment 371883
[details]
Patch
WebKit Commit Bot
Comment 6
2019-06-11 17:24:15 PDT
Comment on
attachment 371883
[details]
Patch Clearing flags on attachment: 371883 Committed
r246342
: <
https://trac.webkit.org/changeset/246342
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug