ECMA262: https://tc39.es/ecma262/#sec-proxycreate (step 4) Test262: https://test262.report/browse/built-ins/Proxy/create-handler-is-revoked-proxy.js
Created attachment 371852 [details] Patch
Comment on attachment 371852 [details] Patch r=me
(In reply to Saam Barati from comment #2) > Comment on attachment 371852 [details] > Patch > > r=me Thanks for review, is there anything I could do to help get this merged?
(In reply to Alexey Shvayka from comment #3) > (In reply to Saam Barati from comment #2) > > Comment on attachment 371852 [details] > > Patch > > > > r=me > > Thanks for review, is there anything I could do to help get this merged? Generally, you can just set the commit queue flag to "?". That lets us know you want the reviewer to set the flag to "+" if they think it's ready to be committed.
Comment on attachment 371852 [details] Patch Rejecting attachment 371852 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 371852, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=371852&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=198755&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 371852 from bug 198755. Fetching: https://bugs.webkit.org/attachment.cgi?id=371852 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Saam Barati']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 5 diffs from patch file(s). patching file JSTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file JSTests/stress/proxy-revoke.js patching file JSTests/test262/expectations.yaml Hunk #1 FAILED at 1140. 1 out of 1 hunk FAILED -- saving rejects to file JSTests/test262/expectations.yaml.rej patching file Source/JavaScriptCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/JavaScriptCore/runtime/ProxyObject.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Saam Barati']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/12511323
Created attachment 372369 [details] Patch Fix merge conflict. Thank you for the tip, I have found --request-commit flag.
Created attachment 376082 [details] Patch Rebase patch.
Looks like Saam already reviewed this, so you don't actually need to set r? again. If you replace the `NOBODY (OOPS!)` in the ChangeLogs and resubmit with just cq? (i.e. --no-review --request-commit), then we can just land it. :)
Created attachment 376722 [details] Patch Set reviewer.
Comment on attachment 376722 [details] Patch Clearing flags on attachment: 376722 Committed r248880: <https://trac.webkit.org/changeset/248880>
All reviewed patches have been landed. Closing bug.
<rdar://problem/54492418>