REGRESSION (r244436): IndexedDB Uint8Array returned as ArrayBuffer

[E.J. Daly]

Saving data in IndexedDB, with key data of type Uint8Array.

When reading the data back out, the data is of type ArrayBuffer.

Doesn't seem to affect non-keyPath fields.

For example:

Input: {
  id: Uint8Array(4),
  data: Uint8Array(8)
}

Output: {
  id: ArrayBuffer {byteLength: 4}
  data: Uint8Array(8)
}

Seeing this on Technology Preview Release 84
Not seeing this on Safari 12.1

[E.J. Daly]

Created attachment 371805 [details]
Example output

[E.J. Daly]

Created attachment 371806 [details]
Example script to reproduce

[Radar WebKit Bug Importer]

<rdar://problem/51614053>

[Sihui Liu]

Created attachment 372785 [details]
Patch

[EWS Watchlist]

Comment on attachment 372785 [details]
Patch

Attachment 372785 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/12564671

New failing tests:
imported/w3c/web-platform-tests/IndexedDB/idb_binary_key_conversion.htm
imported/w3c/web-platform-tests/IndexedDB/idbfactory_cmp4.htm
storage/indexeddb/modern/binary-keys-1.html
storage/indexeddb/modern/binary-keys-1-private.html
imported/w3c/web-platform-tests/IndexedDB/idb-binary-key-roundtrip.htm

[EWS Watchlist]

Created attachment 372792 [details]
Archive of layout-test-results from ews107 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 372785 [details]
Patch

Attachment 372785 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/12564727

New failing tests:
imported/w3c/web-platform-tests/IndexedDB/idb_binary_key_conversion.htm
imported/w3c/web-platform-tests/IndexedDB/idbfactory_cmp4.htm
storage/indexeddb/modern/binary-keys-1.html
storage/indexeddb/modern/binary-keys-1-private.html
imported/w3c/web-platform-tests/IndexedDB/idb-binary-key-roundtrip.htm

[EWS Watchlist]

Created attachment 372796 [details]
Archive of layout-test-results from ews100 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 372785 [details]
Patch

Attachment 372785 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/12564720

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 372798 [details]
Archive of layout-test-results from ews115 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 372785 [details]
Patch

Attachment 372785 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/12564730

New failing tests:
imported/w3c/web-platform-tests/IndexedDB/idb_binary_key_conversion.htm
imported/w3c/web-platform-tests/IndexedDB/idbfactory_cmp4.htm
storage/indexeddb/modern/binary-keys-1.html
storage/indexeddb/modern/binary-keys-1-private.html
imported/w3c/web-platform-tests/IndexedDB/idb-binary-key-roundtrip.htm

[EWS Watchlist]

Created attachment 372800 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.14.5

[Sihui Liu]

Created attachment 372803 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 372803 [details]
Patch

Clearing flags on attachment: 372803

Committed r246770: <https://trac.webkit.org/changeset/246770>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.