Bug 198734 - [WPE][GTK] bubblewrap sandbox should grant access to web extensions directory
Summary: [WPE][GTK] bubblewrap sandbox should grant access to web extensions directory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-10 16:24 PDT by Michael Catanzaro
Modified: 2019-06-11 01:01 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.33 KB, patch)
2019-06-10 16:26 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews213 for win-future (13.69 MB, application/zip)
2019-06-10 21:19 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2019-06-10 16:24:56 PDT
bubblewrap sandbox should grant access to web extensions directory, or web extensions won't be loadable.
Comment 1 Michael Catanzaro 2019-06-10 16:26:32 PDT
Created attachment 371792 [details]
Patch
Comment 2 Build Bot 2019-06-10 16:28:51 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Build Bot 2019-06-10 21:19:17 PDT
Comment on attachment 371792 [details]
Patch

Attachment 371792 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12440150

New failing tests:
imported/blink/compositing/layer-creation/iframe-clip-removed.html
Comment 4 Build Bot 2019-06-10 21:19:19 PDT
Created attachment 371819 [details]
Archive of layout-test-results from ews213 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews213  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 5 WebKit Commit Bot 2019-06-11 01:01:45 PDT
Comment on attachment 371792 [details]
Patch

Clearing flags on attachment: 371792

Committed r246305: <https://trac.webkit.org/changeset/246305>
Comment 6 WebKit Commit Bot 2019-06-11 01:01:46 PDT
All reviewed patches have been landed.  Closing bug.