...
This will leave us with how things were, with Gigacage enabled, but no PAC cage.
Created attachment 371779 [details] WIP testing
Attachment 371779 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h:36: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h:37: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/ArrayBufferView.h:179: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] ERROR: Source/JavaScriptCore/runtime/ArrayBufferView.h:195: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] ERROR: Source/JavaScriptCore/runtime/JSArrayBufferView.cpp:53: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WTF/wtf/CagedPtr.h:39: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/CagedPtr.h:101: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/CagedPtr.h:102: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/CagedUniquePtr.h:84: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/CagedUniquePtr.h:135: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/Options.h:496: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/Options.h:495: One space before end of line comments [whitespace/comments] [5] ERROR: Source/JavaScriptCore/runtime/Options.h:495: Should have a space between // and comment [whitespace/comments] [4] Total errors found: 14 in 44 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 371790 [details] patch
Attachment 371790 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/ChangeLog:15: Line contains tab character. [whitespace/tab] [5] ERROR: Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h:36: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h:37: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/ArrayBufferView.h:179: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] ERROR: Source/JavaScriptCore/runtime/ArrayBufferView.h:195: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] ERROR: Source/JavaScriptCore/runtime/JSArrayBufferView.cpp:53: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WTF/wtf/CagedPtr.h:39: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/CagedPtr.h:101: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/CagedPtr.h:102: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/CagedUniquePtr.h:84: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/CagedUniquePtr.h:135: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/Options.h:496: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/Options.h:495: One space before end of line comments [whitespace/comments] [5] ERROR: Source/JavaScriptCore/runtime/Options.h:495: Should have a space between // and comment [whitespace/comments] [4] Total errors found: 15 in 47 files If any of these errors are false positives, please file a bug against check-webkit-style.
Is this just a revert?
(In reply to Keith Miller from comment #6) > Is this just a revert? Yes. See the changelog
Comment on attachment 371790 [details] patch r=me
(In reply to Saam Barati from comment #7) > (In reply to Keith Miller from comment #6) > > Is this just a revert? > > Yes. See the changelog Specifically, this rolls out: r245064, r245145, r245168, r245313, r245432, r245622
Created attachment 371848 [details] patch for landing Thanks for the review.
Comment on attachment 371848 [details] patch for landing Clearing flags on attachment: 371848 Committed r246322: <https://trac.webkit.org/changeset/246322>
All reviewed patches have been landed. Closing bug.
<rdar://problem/51628704>
Re-opened since this is blocked by bug 198796