Bug 198718 – Add visualization of touch action regions

• Status: RESOLVED
• Resolution: FIXED
• Component: UI Events

[Simon Fraser (smfr)]

Add visualization of touch action regions

[Simon Fraser (smfr)]

Created attachment 371744 [details]
Patch

[EWS Watchlist]

Comment on attachment 371744 [details]
Patch

Attachment 371744 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/12434542

New failing tests:
http/tests/cache/disk-cache/redirect-chain-limits.html

[EWS Watchlist]

Created attachment 371755 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.14.5

[Antoine Quint]

Comment on attachment 371744 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371744&action=review

> Source/WebCore/rendering/RenderLayerBacking.cpp:2769
> +        { TouchAction::PinchZoom, "p-z"_s, { 16, 4.5 }, 249, 171, 80 },

Maybe "pinch" would be catchier here.

> Source/WebCore/rendering/RenderLayerBacking.cpp:2797
> +//        imageContext.setShadow({ }, 2, Color(255, 255, 255, 200));

You should probably remove those commented lines before landing.

[Simon Fraser (smfr)]

Created attachment 371785 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 371785 [details]
Patch

Clearing flags on attachment: 371785

Committed r246301: <https://trac.webkit.org/changeset/246301>

[Radar WebKit Bug Importer]

<rdar://problem/51793054>