Bug 198718 - Add visualization of touch action regions
Summary: Add visualization of touch action regions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-10 08:06 PDT by Simon Fraser (smfr)
Modified: 2019-06-16 20:43 PDT (History)
6 users (show)

See Also:


Attachments
Patch (9.47 KB, patch)
2019-06-10 08:09 PDT, Simon Fraser (smfr)
graouts: review+
ews: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (2.54 MB, application/zip)
2019-06-10 10:11 PDT, Build Bot
no flags Details
Patch (10.09 KB, patch)
2019-06-10 15:39 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2019-06-10 08:06:52 PDT
Add visualization of touch action regions
Comment 1 Simon Fraser (smfr) 2019-06-10 08:09:25 PDT
Created attachment 371744 [details]
Patch
Comment 2 Build Bot 2019-06-10 10:11:38 PDT
Comment on attachment 371744 [details]
Patch

Attachment 371744 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/12434542

New failing tests:
http/tests/cache/disk-cache/redirect-chain-limits.html
Comment 3 Build Bot 2019-06-10 10:11:41 PDT
Created attachment 371755 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.14.5
Comment 4 Antoine Quint 2019-06-10 11:54:41 PDT
Comment on attachment 371744 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371744&action=review

> Source/WebCore/rendering/RenderLayerBacking.cpp:2769
> +        { TouchAction::PinchZoom, "p-z"_s, { 16, 4.5 }, 249, 171, 80 },

Maybe "pinch" would be catchier here.

> Source/WebCore/rendering/RenderLayerBacking.cpp:2797
> +//        imageContext.setShadow({ }, 2, Color(255, 255, 255, 200));

You should probably remove those commented lines before landing.
Comment 5 Simon Fraser (smfr) 2019-06-10 15:39:31 PDT
Created attachment 371785 [details]
Patch
Comment 6 WebKit Commit Bot 2019-06-10 17:54:18 PDT
Comment on attachment 371785 [details]
Patch

Clearing flags on attachment: 371785

Committed r246301: <https://trac.webkit.org/changeset/246301>
Comment 7 Radar WebKit Bug Importer 2019-06-16 20:43:15 PDT
<rdar://problem/51793054>