Bug 198717 - Event region should be set on scrolledContentsLayer if it exists
Summary: Event region should be set on scrolledContentsLayer if it exists
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-10 07:35 PDT by Antti Koivisto
Modified: 2019-06-11 00:51 PDT (History)
4 users (show)

See Also:


Attachments
patch (10.92 KB, patch)
2019-06-10 07:51 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews211 for win-future (13.65 MB, application/zip)
2019-06-10 11:46 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2019-06-10 07:35:30 PDT
Event region for overflow:scroll layer does not move correctly during scrolling. This causes us to miscompute touch-actions.
Comment 1 Antti Koivisto 2019-06-10 07:36:16 PDT
<rdar://problem/51572169>
Comment 2 Antti Koivisto 2019-06-10 07:51:11 PDT
Created attachment 371742 [details]
patch
Comment 3 Simon Fraser (smfr) 2019-06-10 10:29:56 PDT
Comment on attachment 371742 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371742&action=review

> LayoutTests/pointerevents/ios/touch-action-region-backing-sharing-expected.txt:-4
> -  (deep color 1)

Not sure why these changed.
Comment 4 Build Bot 2019-06-10 11:46:22 PDT
Comment on attachment 371742 [details]
patch

Attachment 371742 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12435063

New failing tests:
imported/blink/fast/canvas/canvas-clip-stack-persistence.html
storage/indexeddb/index-cursor.html
Comment 5 Build Bot 2019-06-10 11:46:24 PDT
Created attachment 371766 [details]
Archive of layout-test-results from ews211 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 6 Antoine Quint 2019-06-10 11:52:00 PDT
(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 371742 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=371742&action=review
> 
> > LayoutTests/pointerevents/ios/touch-action-region-backing-sharing-expected.txt:-4
> > -  (deep color 1)
> 
> Not sure why these changed.

I think this might depend on the Simulator device, although maybe not?
Comment 7 Antti Koivisto 2019-06-10 13:15:52 PDT
> I think this might depend on the Simulator device, although maybe not?

Looking into this I noticed that pointerevents/ios tests are not running by default in opensource bots. Is there some reason for that?
Comment 8 Simon Fraser (smfr) 2019-06-10 13:22:58 PDT
(In reply to Antti Koivisto from comment #7)
> > I think this might depend on the Simulator device, although maybe not?
> 
> Looking into this I noticed that pointerevents/ios tests are not running by
> default in opensource bots. Is there some reason for that?

Presumably their implementation is tied to touch events.
Comment 9 WebKit Commit Bot 2019-06-10 13:43:24 PDT
Comment on attachment 371742 [details]
patch

Clearing flags on attachment: 371742

Committed r246278: <https://trac.webkit.org/changeset/246278>
Comment 10 WebKit Commit Bot 2019-06-10 13:43:25 PDT
All reviewed patches have been landed.  Closing bug.
Comment 11 Antoine Quint 2019-06-11 00:51:09 PDT
(In reply to Simon Fraser (smfr) from comment #8)
> (In reply to Antti Koivisto from comment #7)
> > > I think this might depend on the Simulator device, although maybe not?
> > 
> > Looking into this I noticed that pointerevents/ios tests are not running by
> > default in opensource bots. Is there some reason for that?
> 
> Presumably their implementation is tied to touch events.

That's correct.