Bug 198717 – Event region should be set on scrolledContentsLayer if it exists

• Status: RESOLVED
• Resolution: FIXED
• Component: Scrolling

[Antti Koivisto]

Event region for overflow:scroll layer does not move correctly during scrolling. This causes us to miscompute touch-actions.

[Antti Koivisto]

<rdar://problem/51572169>

[Antti Koivisto]

Created attachment 371742 [details]
patch

[Simon Fraser (smfr)]

Comment on attachment 371742 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371742&action=review

> LayoutTests/pointerevents/ios/touch-action-region-backing-sharing-expected.txt:-4
> -  (deep color 1)

Not sure why these changed.

[EWS Watchlist]

Comment on attachment 371742 [details]
patch

Attachment 371742 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12435063

New failing tests:
imported/blink/fast/canvas/canvas-clip-stack-persistence.html
storage/indexeddb/index-cursor.html

[EWS Watchlist]

Created attachment 371766 [details]
Archive of layout-test-results from ews211 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Antoine Quint]

(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 371742 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=371742&action=review
> 
> > LayoutTests/pointerevents/ios/touch-action-region-backing-sharing-expected.txt:-4
> > -  (deep color 1)
> 
> Not sure why these changed.

I think this might depend on the Simulator device, although maybe not?

[Antti Koivisto]

> I think this might depend on the Simulator device, although maybe not?

Looking into this I noticed that pointerevents/ios tests are not running by default in opensource bots. Is there some reason for that?

[Simon Fraser (smfr)]

(In reply to Antti Koivisto from comment #7)
> > I think this might depend on the Simulator device, although maybe not?
> 
> Looking into this I noticed that pointerevents/ios tests are not running by
> default in opensource bots. Is there some reason for that?

Presumably their implementation is tied to touch events.

[WebKit Commit Bot]

Comment on attachment 371742 [details]
patch

Clearing flags on attachment: 371742

Committed r246278: <https://trac.webkit.org/changeset/246278>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Antoine Quint]

(In reply to Simon Fraser (smfr) from comment #8)
> (In reply to Antti Koivisto from comment #7)
> > > I think this might depend on the Simulator device, although maybe not?
> > 
> > Looking into this I noticed that pointerevents/ios tests are not running by
> > default in opensource bots. Is there some reason for that?
> 
> Presumably their implementation is tied to touch events.

That's correct.