Bug 198713 - [WPE][Qt] Port to new wpe_fdo_egl_exported_image API
Summary: [WPE][Qt] Port to new wpe_fdo_egl_exported_image API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords:
: 198716 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-06-10 06:37 PDT by Philippe Normand
Modified: 2019-06-10 07:12 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.63 KB, patch)
2019-06-10 06:40 PDT, Philippe Normand 		cgarcia: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2019-06-10 06:37:40 PDT 
Patch incoming
Comment 1 Philippe Normand 2019-06-10 06:40:25 PDT 
Created attachment 371737 [details]
Patch
Comment 2 Carlos Garcia Campos 2019-06-10 06:47:41 PDT 
Comment on attachment 371737 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371737&action=review

> Source/WebKit/UIProcess/API/wpe/qt/WPEQtViewBackend.cpp:212
> -    RELEASE_ASSERT(m_lockedImage == EGL_NO_IMAGE_KHR);
> +    RELEASE_ASSERT(m_lockedImage == nullptr);

!m_lockedImage

> Source/cmake/OptionsWPE.cmake:175
> -    pkg_check_modules(WPE_BACKEND_FDO REQUIRED wpebackend-fdo-1.0)
> +    pkg_check_modules(WPE_BACKEND_FDO REQUIRED "wpebackend-fdo-1.0 >= 1.3.0")

Could you use find_package(WPEBackend-fdo 1.3.0) instead? You will have to change the INCLUDE_DIRS and LIBRARIES vars to WPEBACKEND_FDO_INCLUDE_DIRS and WPEBACKEND_FDO_LIBRARIES. That would make QtWPE consistent with wpe and gtk.
Comment 3 Philippe Normand 2019-06-10 07:05:47 PDT 
Committed r246257: <https://trac.webkit.org/changeset/246257>
Comment 4 Adrian Perez 2019-06-10 07:12:00 PDT 
*** Bug 198716 has been marked as a duplicate of this bug. ***