Make new Symbol/Promise API public
Created attachment 371730 [details] Patch
Attachment 371730 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/API/JSValue.h:552: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] ERROR: Source/JavaScriptCore/API/JSObjectRef.h:576: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRef.h:588: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRef.h:601: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRef.h:601: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRef.h:601: The parameter name "attributes" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRef.h:613: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSValueRef.h:54: JSC_API_AVAILABLE is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/API/JSValueRef.h:152: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/tests/testapi.mm:654: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 10 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 371731 [details] Patch
Attachment 371731 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/API/JSValue.h:552: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] ERROR: Source/JavaScriptCore/API/JSObjectRef.h:576: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRef.h:588: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRef.h:601: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRef.h:601: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRef.h:601: The parameter name "attributes" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRef.h:613: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSValueRef.h:54: JSC_API_AVAILABLE is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/API/JSValueRef.h:152: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/tests/testapi.mm:654: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 10 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Windows build failure seems to be something with generating DerivedSources/JavaScriptCore/CombinedDomains.json. From what I can tell that seems like an inspector thing, which I shouldn't have changed... I guess I'll land this and watch the windows bots.
Comment on attachment 371731 [details] Patch Clearing flags on attachment: 371731 Committed r246265: <https://trac.webkit.org/changeset/246265>
All reviewed patches have been landed. Closing bug.
<rdar://problem/51584049>