RESOLVED FIXED 198709
Make new Symbol/Promise API public 
https://bugs.webkit.org/show_bug.cgi?id=198709
Summary Make new Symbol/Promise API public
Keith Miller
Reported 2019-06-10 02:25:59 PDT
Make new Symbol/Promise API public
Attachments
Patch (30.21 KB, patch)
2019-06-10 02:28 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (31.59 KB, patch)
2019-06-10 02:31 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2019-06-10 02:28:14 PDT
Created attachment 371730 [details] Patch
EWS Watchlist
Comment 2 2019-06-10 02:29:33 PDT
Attachment 371730 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/API/JSValue.h:552: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] ERROR: Source/JavaScriptCore/API/JSObjectRef.h:576: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRef.h:588: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRef.h:601: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRef.h:601: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRef.h:601: The parameter name "attributes" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRef.h:613: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSValueRef.h:54: JSC_API_AVAILABLE is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/API/JSValueRef.h:152: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/tests/testapi.mm:654: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 10 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Keith Miller
Comment 3 2019-06-10 02:31:32 PDT
Created attachment 371731 [details] Patch
EWS Watchlist
Comment 4 2019-06-10 02:34:33 PDT
Attachment 371731 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/API/JSValue.h:552: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] ERROR: Source/JavaScriptCore/API/JSObjectRef.h:576: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRef.h:588: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRef.h:601: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRef.h:601: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRef.h:601: The parameter name "attributes" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRef.h:613: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSValueRef.h:54: JSC_API_AVAILABLE is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/API/JSValueRef.h:152: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/tests/testapi.mm:654: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 10 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Keith Miller
Comment 5 2019-06-10 09:04:37 PDT
Windows build failure seems to be something with generating DerivedSources/JavaScriptCore/CombinedDomains.json. From what I can tell that seems like an inspector thing, which I shouldn't have changed... I guess I'll land this and watch the windows bots.
WebKit Commit Bot
Comment 6 2019-06-10 09:35:06 PDT
Comment on attachment 371731 [details] Patch Clearing flags on attachment: 371731 Committed r246265: <https://trac.webkit.org/changeset/246265>
WebKit Commit Bot
Comment 7 2019-06-10 09:35:07 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-06-10 09:38:58 PDT
<rdar://problem/51584049>
Note You need to log in before you can comment on or make changes to this bug.