Bug 198697 - [LFC][IFC] Add support for vertical-align: top and bottom
Summary: [LFC][IFC] Add support for vertical-align: top and bottom
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-08 18:58 PDT by zalan
Modified: 2019-06-15 07:03 PDT (History)
7 users (show)

See Also:

Attachments
Patch (13.40 KB, patch)
2019-06-08 19:05 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (13.40 KB, patch)
2019-06-08 19:07 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-06-08 18:58:22 PDT 
in addition to baseline
Comment 1 Radar WebKit Bug Importer 2019-06-08 18:58:44 PDT 
<rdar://problem/51556188>
Comment 2 zalan 2019-06-08 19:05:31 PDT 
Created attachment 371695 [details]
Patch
Comment 3 EWS Watchlist 2019-06-08 19:06:27 PDT 
Attachment 371695 [details] did not pass style-queue:


ERROR: Source/WebCore/layout/inlineformatting/InlineLine.cpp:95:  Missing space before ( in switch(  [whitespace/parens] [5]
ERROR: Source/WebCore/layout/inlineformatting/InlineLine.cpp:290:  Missing space before ( in switch(  [whitespace/parens] [5]
ERROR: Source/WebCore/layout/inlineformatting/InlineLine.cpp:292:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 3 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 zalan 2019-06-08 19:07:31 PDT 
Created attachment 371696 [details]
Patch
Comment 5 WebKit Commit Bot 2019-06-15 07:03:29 PDT 
Comment on attachment 371696 [details]
Patch

Clearing flags on attachment: 371696

Committed r246457: <https://trac.webkit.org/changeset/246457>
Comment 6 WebKit Commit Bot 2019-06-15 07:03:31 PDT 
All reviewed patches have been landed.  Closing bug.