RESOLVED FIXED198697
[LFC][IFC] Add support for vertical-align: top and bottom 
https://bugs.webkit.org/show_bug.cgi?id=198697
Summary [LFC][IFC] Add support for vertical-align: top and bottom
alan
Reported 2019-06-08 18:58:22 PDT
in addition to baseline
Attachments
Patch (13.40 KB, patch)
2019-06-08 19:05 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (13.40 KB, patch)
2019-06-08 19:07 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-06-08 18:58:44 PDT
<rdar://problem/51556188>
alan
Comment 2 2019-06-08 19:05:31 PDT
Created attachment 371695 [details] Patch
EWS Watchlist
Comment 3 2019-06-08 19:06:27 PDT
Attachment 371695 [details] did not pass style-queue: ERROR: Source/WebCore/layout/inlineformatting/InlineLine.cpp:95: Missing space before ( in switch( [whitespace/parens] [5] ERROR: Source/WebCore/layout/inlineformatting/InlineLine.cpp:290: Missing space before ( in switch( [whitespace/parens] [5] ERROR: Source/WebCore/layout/inlineformatting/InlineLine.cpp:292: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 3 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
alan
Comment 4 2019-06-08 19:07:31 PDT
Created attachment 371696 [details] Patch
WebKit Commit Bot
Comment 5 2019-06-15 07:03:29 PDT
Comment on attachment 371696 [details] Patch Clearing flags on attachment: 371696 Committed r246457: <https://trac.webkit.org/changeset/246457>
WebKit Commit Bot
Comment 6 2019-06-15 07:03:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.