Bug 198696 - Drag starting state can get stuck even though the drag has ended
Summary: Drag starting state can get stuck even though the drag has ended
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-08 18:39 PDT by Dean Jackson
Modified: 2019-06-09 13:03 PDT (History)
2 users (show)

See Also:


Attachments
Patch (4.18 KB, patch)
2019-06-08 18:41 PDT, Dean Jackson
wenson_hsieh: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2019-06-08 18:39:40 PDT
Drag starting state can get stuck even though the drag has ended
Comment 1 Dean Jackson 2019-06-08 18:41:35 PDT
Created attachment 371693 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2019-06-08 18:42:30 PDT
<rdar://problem/51556045>
Comment 3 Wenson Hsieh 2019-06-08 18:44:39 PDT
Comment on attachment 371693 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371693&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:6746
> +        RELEASE_LOG(DragAndDrop, "Drag session willAnimateLiftWithAnimator: %p (animation completion block fired)", session);

Nit - this is redundant in the case where finalPosition == UIViewAnimatingPositionStart. Maybe add this logging state as an `else` clause of the `if (finalPosition == UIViewAnimatingPositionStart)` below?
Comment 4 Dean Jackson 2019-06-09 13:03:34 PDT
Committed r246239: <https://trac.webkit.org/changeset/246239>