Bug 198686 – [LFC][IFC] Make baselines alignment explicit in Line

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

This is in preparation for adding non-baseline vertical alignment support.

[Radar WebKit Bug Importer]

<rdar://problem/51545175>

[zalan]

Created attachment 371646 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 371646 [details]
Patch

Clearing flags on attachment: 371646

Committed r246234: <https://trac.webkit.org/changeset/246234>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Sam Weinig]

Comment on attachment 371646 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371646&action=review

> Source/WebCore/layout/inlineformatting/InlineFormattingContextLineLayout.cpp:314
> -    auto lineBox = Display::Rect { lineContent.logicalTop(), lineContent.logicalLeft(), 0 , !lineContent.isVisuallyEmpty() ? lineContent.logicalHeight() : LayoutUnit { } };
> +    auto lineBox = Display::Rect { lineContent.logicalTop(), lineContent.logicalLeft(), 0, !lineContent.isVisuallyEmpty() ? lineContent.logicalHeight() : LayoutUnit { } };

Minor nit, but it's a bit confusing to call this variable lineBox, now that a LineBox contains more than just the line box rect. Maybe lineBoxRect?

[zalan]

(In reply to Sam Weinig from comment #5)
> Comment on attachment 371646 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=371646&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineFormattingContextLineLayout.cpp:314
> > -    auto lineBox = Display::Rect { lineContent.logicalTop(), lineContent.logicalLeft(), 0 , !lineContent.isVisuallyEmpty() ? lineContent.logicalHeight() : LayoutUnit { } };
> > +    auto lineBox = Display::Rect { lineContent.logicalTop(), lineContent.logicalLeft(), 0, !lineContent.isVisuallyEmpty() ? lineContent.logicalHeight() : LayoutUnit { } };
> 
> Minor nit, but it's a bit confusing to call this variable lineBox, now that
> a LineBox contains more than just the line box rect. Maybe lineBoxRect?
You are right! I'll take care of it!

[zalan]

(In reply to Sam Weinig from comment #5)
> Comment on attachment 371646 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=371646&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineFormattingContextLineLayout.cpp:314
> > -    auto lineBox = Display::Rect { lineContent.logicalTop(), lineContent.logicalLeft(), 0 , !lineContent.isVisuallyEmpty() ? lineContent.logicalHeight() : LayoutUnit { } };
> > +    auto lineBox = Display::Rect { lineContent.logicalTop(), lineContent.logicalLeft(), 0, !lineContent.isVisuallyEmpty() ? lineContent.logicalHeight() : LayoutUnit { } };
> 
> Minor nit, but it's a bit confusing to call this variable lineBox, now that
> a LineBox contains more than just the line box rect. Maybe lineBoxRect?
https://trac.webkit.org/changeset/246486