Bug 198686 - [LFC][IFC] Make baselines alignment explicit in Line
Summary: [LFC][IFC] Make baselines alignment explicit in Line
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-07 21:02 PDT by zalan
Modified: 2019-06-16 14:05 PDT (History)
7 users (show)

See Also:


Attachments
Patch (13.04 KB, patch)
2019-06-07 21:08 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-06-07 21:02:53 PDT
This is in preparation for adding non-baseline vertical alignment support.
Comment 1 Radar WebKit Bug Importer 2019-06-07 21:04:04 PDT
<rdar://problem/51545175>
Comment 2 zalan 2019-06-07 21:08:57 PDT
Created attachment 371646 [details]
Patch
Comment 3 WebKit Commit Bot 2019-06-08 11:48:47 PDT
Comment on attachment 371646 [details]
Patch

Clearing flags on attachment: 371646

Committed r246234: <https://trac.webkit.org/changeset/246234>
Comment 4 WebKit Commit Bot 2019-06-08 11:48:49 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Sam Weinig 2019-06-09 18:25:08 PDT
Comment on attachment 371646 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371646&action=review

> Source/WebCore/layout/inlineformatting/InlineFormattingContextLineLayout.cpp:314
> -    auto lineBox = Display::Rect { lineContent.logicalTop(), lineContent.logicalLeft(), 0 , !lineContent.isVisuallyEmpty() ? lineContent.logicalHeight() : LayoutUnit { } };
> +    auto lineBox = Display::Rect { lineContent.logicalTop(), lineContent.logicalLeft(), 0, !lineContent.isVisuallyEmpty() ? lineContent.logicalHeight() : LayoutUnit { } };

Minor nit, but it's a bit confusing to call this variable lineBox, now that a LineBox contains more than just the line box rect. Maybe lineBoxRect?
Comment 6 zalan 2019-06-14 21:21:59 PDT
(In reply to Sam Weinig from comment #5)
> Comment on attachment 371646 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=371646&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineFormattingContextLineLayout.cpp:314
> > -    auto lineBox = Display::Rect { lineContent.logicalTop(), lineContent.logicalLeft(), 0 , !lineContent.isVisuallyEmpty() ? lineContent.logicalHeight() : LayoutUnit { } };
> > +    auto lineBox = Display::Rect { lineContent.logicalTop(), lineContent.logicalLeft(), 0, !lineContent.isVisuallyEmpty() ? lineContent.logicalHeight() : LayoutUnit { } };
> 
> Minor nit, but it's a bit confusing to call this variable lineBox, now that
> a LineBox contains more than just the line box rect. Maybe lineBoxRect?
You are right! I'll take care of it!
Comment 7 zalan 2019-06-16 14:05:07 PDT
(In reply to Sam Weinig from comment #5)
> Comment on attachment 371646 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=371646&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineFormattingContextLineLayout.cpp:314
> > -    auto lineBox = Display::Rect { lineContent.logicalTop(), lineContent.logicalLeft(), 0 , !lineContent.isVisuallyEmpty() ? lineContent.logicalHeight() : LayoutUnit { } };
> > +    auto lineBox = Display::Rect { lineContent.logicalTop(), lineContent.logicalLeft(), 0, !lineContent.isVisuallyEmpty() ? lineContent.logicalHeight() : LayoutUnit { } };
> 
> Minor nit, but it's a bit confusing to call this variable lineBox, now that
> a LineBox contains more than just the line box rect. Maybe lineBoxRect?
https://trac.webkit.org/changeset/246486