Bug 198682 - import-w3c-tests should respect WEBKIT_OUTPUTDIR
Summary: import-w3c-tests should respect WEBKIT_OUTPUTDIR
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: youenn fablet
Keywords: InRadar
Depends on:
Reported: 2019-06-07 15:02 PDT by Daniel Bates
Modified: 2019-06-14 08:54 PDT (History)
5 users (show)

See Also:

Patch (4.61 KB, patch)
2019-06-11 11:46 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (4.44 KB, patch)
2019-06-11 12:11 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (6.11 KB, patch)
2019-06-12 10:36 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2019-06-07 15:02:51 PDT
Seen with WebKit r246069.

Ran Tools/Scripts/import-w3c-tests yesterday and it checked out the w3c repo into a WebKitBuild directory under my current checkout, but this is *not* the WebKitBuild directory I use. All of our other tools know to respect the environment variable WEBKIT_OUTPUTDIR. We should make import-w3c-tests smarter.

Steps to reproduce:

1. export WEBKIT_OUTPUTDIR="/tmp/Blah"
3. Tools/Scripts/import-w3c-tests -t web-platform-tests/content-security-policy

Then the Web Platform Tests checkout should be in /tmp/Blah/w3c-tests, but it is not.
Comment 1 Radar WebKit Bug Importer 2019-06-07 15:03:05 PDT
Comment 2 youenn fablet 2019-06-11 11:46:22 PDT
Created attachment 371859 [details]
Comment 3 youenn fablet 2019-06-11 12:11:01 PDT
Created attachment 371862 [details]
Comment 4 youenn fablet 2019-06-12 10:36:00 PDT
Created attachment 371971 [details]
Comment 5 WebKit Commit Bot 2019-06-14 08:54:01 PDT
Comment on attachment 371971 [details]

Clearing flags on attachment: 371971

Committed r246434: <https://trac.webkit.org/changeset/246434>
Comment 6 WebKit Commit Bot 2019-06-14 08:54:03 PDT
All reviewed patches have been landed.  Closing bug.