RESOLVED FIXED198682
import-w3c-tests should respect WEBKIT_OUTPUTDIR 
https://bugs.webkit.org/show_bug.cgi?id=198682
Summary import-w3c-tests should respect WEBKIT_OUTPUTDIR
Daniel Bates
Reported 2019-06-07 15:02:51 PDT
Seen with WebKit r246069. Ran Tools/Scripts/import-w3c-tests yesterday and it checked out the w3c repo into a WebKitBuild directory under my current checkout, but this is *not* the WebKitBuild directory I use. All of our other tools know to respect the environment variable WEBKIT_OUTPUTDIR. We should make import-w3c-tests smarter. Steps to reproduce: 1. export WEBKIT_OUTPUTDIR="/tmp/Blah" 2. mkdir -p $WEBKIT_OUTPUTDIR 3. Tools/Scripts/import-w3c-tests -t web-platform-tests/content-security-policy Then the Web Platform Tests checkout should be in /tmp/Blah/w3c-tests, but it is not.
Attachments
Patch (4.61 KB, patch)
2019-06-11 11:46 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (4.44 KB, patch)
2019-06-11 12:11 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (6.11 KB, patch)
2019-06-12 10:36 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-06-07 15:03:05 PDT
<rdar://problem/51536931>
youenn fablet
Comment 2 2019-06-11 11:46:22 PDT
Created attachment 371859 [details] Patch
youenn fablet
Comment 3 2019-06-11 12:11:01 PDT
Created attachment 371862 [details] Patch
youenn fablet
Comment 4 2019-06-12 10:36:00 PDT
Created attachment 371971 [details] Patch
WebKit Commit Bot
Comment 5 2019-06-14 08:54:01 PDT
Comment on attachment 371971 [details] Patch Clearing flags on attachment: 371971 Committed r246434: <https://trac.webkit.org/changeset/246434>
WebKit Commit Bot
Comment 6 2019-06-14 08:54:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.