Bug 198681 - Extend quirks to emulate bold/italic/underline in hidden editable areas
Summary: Extend quirks to emulate bold/italic/underline in hidden editable areas
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-07 14:59 PDT by Megan Gardner
Modified: 2019-06-07 17:48 PDT (History)
5 users (show)

See Also:


Attachments
Patch (12.27 KB, patch)
2019-06-07 15:03 PDT, Megan Gardner
no flags Details | Formatted Diff | Diff
Patch (12.22 KB, patch)
2019-06-07 15:51 PDT, Megan Gardner
no flags Details | Formatted Diff | Diff
Patch for landing (12.22 KB, patch)
2019-06-07 16:54 PDT, Megan Gardner
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2019-06-07 14:59:06 PDT
Extend quirks to emulate bold/italic/underline in hidden editable areas
Comment 1 Megan Gardner 2019-06-07 15:03:15 PDT
Created attachment 371614 [details]
Patch
Comment 2 Wenson Hsieh 2019-06-07 15:15:20 PDT
Comment on attachment 371614 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371614&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3125
> +static bool shouldSynthezieKeyEvents(WKContentView *contentView)
> +{
> +    if (contentView.focusedElementInformation.shouldSynthesizeKeyEventsForEditing && contentView.hasHiddenContentEditable)
> +        return true;
> +    return false;
> +}

It seems like this could just be a method like so:

- (BOOL)shouldSynthesizeKeyEvents
{
    return _focusedElementInformation.shouldSynthesizeKeyEventsForEditing && self.hasHiddenContentEditable;
}

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3145
> +    if (shouldSynthezieKeyEvents(self))

"Synthezie"
Comment 3 Megan Gardner 2019-06-07 15:51:36 PDT
Created attachment 371619 [details]
Patch
Comment 4 Megan Gardner 2019-06-07 16:54:51 PDT
Created attachment 371632 [details]
Patch for landing
Comment 5 Megan Gardner 2019-06-07 16:55:32 PDT
<rdar://problem/46430520>
Comment 6 WebKit Commit Bot 2019-06-07 17:48:00 PDT
The commit-queue encountered the following flaky tests while processing attachment 371632 [details]:

resize-observer/element-leak.html bug 198666
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2019-06-07 17:48:48 PDT
Comment on attachment 371632 [details]
Patch for landing

Clearing flags on attachment: 371632

Committed r246226: <https://trac.webkit.org/changeset/246226>
Comment 8 WebKit Commit Bot 2019-06-07 17:48:49 PDT
All reviewed patches have been landed.  Closing bug.