Bug 198681 – Extend quirks to emulate bold/italic/underline in hidden editable areas

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Megan Gardner]

Extend quirks to emulate bold/italic/underline in hidden editable areas

[Megan Gardner]

Created attachment 371614 [details]
Patch

[Wenson Hsieh]

Comment on attachment 371614 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371614&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3125
> +static bool shouldSynthezieKeyEvents(WKContentView *contentView)
> +{
> +    if (contentView.focusedElementInformation.shouldSynthesizeKeyEventsForEditing && contentView.hasHiddenContentEditable)
> +        return true;
> +    return false;
> +}

It seems like this could just be a method like so:

- (BOOL)shouldSynthesizeKeyEvents
{
    return _focusedElementInformation.shouldSynthesizeKeyEventsForEditing && self.hasHiddenContentEditable;
}

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3145
> +    if (shouldSynthezieKeyEvents(self))

"Synthezie"

[Megan Gardner]

Created attachment 371619 [details]
Patch

[Megan Gardner]

Created attachment 371632 [details]
Patch for landing

[Megan Gardner]

<rdar://problem/46430520>

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 371632 [details]:

resize-observer/element-leak.html bug 198666
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 371632 [details]
Patch for landing

Clearing flags on attachment: 371632

Committed r246226: <https://trac.webkit.org/changeset/246226>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.