Bug 198677 - Update cached-svg-image-with-css-cross-domain.html and svg-image-with-css-cross-domain.html to use square instead of circle
Summary: Update cached-svg-image-with-css-cross-domain.html and svg-image-with-css-cro...
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-07 13:55 PDT by youenn fablet
Modified: 2019-09-09 17:46 PDT (History)
5 users (show)

See Also:

Attachments
Patch (13.54 KB, patch)
2019-06-07 13:57 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-06-07 13:55:35 PDT 
This helps WK1.
Comment 1 youenn fablet 2019-06-07 13:57:22 PDT 
Created attachment 371608 [details]
Patch
Comment 2 youenn fablet 2019-06-07 14:04:54 PDT 
<rdar://problem/51229282>
Comment 3 Alexey Proskuryakov 2019-06-07 16:59:16 PDT 
Circles should cause issues either, if drawn in the same way. What is the state that is different?
Comment 4 youenn fablet 2019-06-10 08:35:32 PDT 
(In reply to Alexey Proskuryakov from comment #3)
> Circles should cause issues either, if drawn in the same way. What is the
> state that is different?

Agreed that this should work with circles as it used to do and is probably a regression in WK1 rendering.
Given the purpose of those two tests is not about rendering, fixing it this way ensures we do not regress the parts of WK1 implementation that these tests were written for.
Comment 5 Alexey Proskuryakov 2019-06-10 23:55:29 PDT 
Makes sense. Can you file a bug about the rendering regression? I'm not quite sure about the details here (is it reproducible? are we confident that it's a regression?)
Comment 6 Ryan Haddad 2019-09-09 17:46:43 PDT 
These tests are passing now, marking as resolved.