Bug 198659 - [GTK] GLContextEGL.h must be built with @no-unify
Summary: [GTK] GLContextEGL.h must be built with @no-unify
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-07 07:54 PDT by Michael Catanzaro
Modified: 2019-06-07 07:57 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2019-06-07 07:54:07 PDT 
[ 87%] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/unified-sources/UnifiedSource-3c72abbe-41.cpp.o
In file included from /home/mcatanzaro/buildroot-2019.05/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/include/X11/Xlib.h:44:0,
                 from /home/mcatanzaro/buildroot-2019.05/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/include/EGL/eglplatform.h:124,
                 from /home/mcatanzaro/buildroot-2019.05/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/include/EGL/egl.h:39,
                 from /home/mcatanzaro/buildroot-2019.05/output/build/webkitgtk-2.25.1/Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:30,
                 from /home/mcatanzaro/buildroot-2019.05/output/build/webkitgtk-2.25.1/DerivedSources/WebCore/unified-sources/UnifiedSource-3c72abbe-26.cpp:5:
/home/mcatanzaro/buildroot-2019.05/output/build/webkitgtk-2.25.1/Source/WebCore/rendering/style/RenderStyleConstants.h:70:5: error: expected identifier before numeric constant
     None        = 0,
     ^

It's clashing with Xlib.h. Any file using the keyword "None" has to either use @no-unify or else rename to avoid clashing with X11's None.
Comment 1 Michael Catanzaro 2019-06-07 07:57:46 PDT 
Committed r246199: <https://trac.webkit.org/changeset/246199>