Bug 198647 - position:fixed inside overflow positioning nodes is jumpy
Summary: position:fixed inside overflow positioning nodes is jumpy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-07 00:42 PDT by Antti Koivisto
Modified: 2019-06-07 07:17 PDT (History)
9 users (show)

See Also:


Attachments
patch (21.98 KB, patch)
2019-06-07 01:07 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2019-06-07 00:42:04 PDT
Fixed needs to take offsets from positioning nodes into account.
Comment 1 Radar WebKit Bug Importer 2019-06-07 00:44:13 PDT
<rdar://problem/51514437>
Comment 2 Antti Koivisto 2019-06-07 01:07:13 PDT
Created attachment 371574 [details]
patch
Comment 3 EWS Watchlist 2019-06-07 01:09:59 PDT
Attachment 371574 [details] did not pass style-queue:


ERROR: Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h:58:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 WebKit Commit Bot 2019-06-07 07:17:55 PDT
Comment on attachment 371574 [details]
patch

Clearing flags on attachment: 371574

Committed r246197: <https://trac.webkit.org/changeset/246197>
Comment 5 WebKit Commit Bot 2019-06-07 07:17:57 PDT
All reviewed patches have been landed.  Closing bug.